From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9142252912 for ; Wed, 5 Mar 2025 18:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741200526; cv=none; b=CntGcx8MEjwkioNbG6ZorNXSVm83AhdSC+FAUDYGlwGQDy0/TzoQLj++Lby7IdLea7o+K5vlZKVde4mW8qhgW5ft7KNBXrzdNOsvlJOHkck2P1dw69bo/yH+24/onPTnZ86Y2DD66Lv+MESsh6aUdD03IwEv6fyXEqAbwykUmYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741200526; c=relaxed/simple; bh=868+/Ff9d2q4wznenD1/aaHMIXsUV2hgGgPWgSB1+G4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oleY4ijDaCc6z/ksdckWdG+oTPV6ble0ddy8rpWWFYHSdps4GLFFrn0XqFHSHT4PoEud4tH2KhI7+Yr7XZRGpBSlE8Pc8nh0ckZxkvHRIAQF5FkL3NmTICCusz86Funilg/v81ojBWDka2FbHp8ZhDY504p42Ha9qRTd80u3MoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CXHAvNuM; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CXHAvNuM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741200525; x=1772736525; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=868+/Ff9d2q4wznenD1/aaHMIXsUV2hgGgPWgSB1+G4=; b=CXHAvNuM7Qs37pqQG1nz/jYHEf6RWFisWGL8tzOSUbDjyG0cuLbPKbsE 6D3PVAVu5r0wT6yx8Hlt09sFhBwqW9gDtA9fdmFCcb23eMpqllTGfM/BY f3csCrPPFaXUc0LRufBmOqNZCrZNXRfuBUN0LOZHbhPrSPs9SiDFfr9sH 9SuBbW1984BakKQae4oSbkbAcxY0UDvWyUigXsAso6u1kt7oLxZ98+U7q 87kS4XEDBuTiqvkk1chLDbm0IliaD8oKK9pONu4Oc1CIl8JfL0Wv83q6/ OqwcBk1IQ4wm4q9LyFjkCzStDxXDkRzfHEYHdSXu3oJf5bDx334wbojDH w==; X-CSE-ConnectionGUID: doYfgPmRRkGFmd3RFbcWRg== X-CSE-MsgGUID: BvHnue5ISkG/6XKN63mDcA== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="52829292" X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="52829292" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 10:48:44 -0800 X-CSE-ConnectionGUID: V55DJKrMT6avW18LVHi6MA== X-CSE-MsgGUID: z/n1uqBgS1S47x4ePazlGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="118576666" Received: from lkp-server02.sh.intel.com (HELO 76cde6cc1f07) ([10.239.97.151]) by fmviesa006.fm.intel.com with ESMTP; 05 Mar 2025 10:48:42 -0800 Received: from kbuild by 76cde6cc1f07 with local (Exim 4.96) (envelope-from ) id 1tptnM-000M3m-0y; Wed, 05 Mar 2025 18:48:40 +0000 Date: Thu, 6 Mar 2025 02:47:55 +0800 From: kernel test robot To: Zack Rusin , dri-devel@lists.freedesktop.org Cc: oe-kbuild-all@lists.linux.dev, Broadcom internal kernel review list , ian.forbes@broadcom.com, martin.krastev@broadcom.com, maaz.mombasawala@broadcom.com, Zack Rusin Subject: Re: [PATCH] drm/vmwgfx: Make sure the dirty tracker is released on surfaces Message-ID: <202503060226.Y7UvsIZE-lkp@intel.com> References: <20250304184942.2127704-1-zack.rusin@broadcom.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304184942.2127704-1-zack.rusin@broadcom.com> Hi Zack, kernel test robot noticed the following build errors: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on linus/master v6.14-rc5 next-20250305] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zack-Rusin/drm-vmwgfx-Make-sure-the-dirty-tracker-is-released-on-surfaces/20250305-025105 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next patch link: https://lore.kernel.org/r/20250304184942.2127704-1-zack.rusin%40broadcom.com patch subject: [PATCH] drm/vmwgfx: Make sure the dirty tracker is released on surfaces config: arm64-randconfig-002-20250305 (https://download.01.org/0day-ci/archive/20250306/202503060226.Y7UvsIZE-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250306/202503060226.Y7UvsIZE-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202503060226.Y7UvsIZE-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function 'vmw_framebuffer_surface_destroy': >> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1236:39: error: invalid use of undefined type 'const struct vmw_res_func' 1236 | surf->res.func->dirty_free(&surf->res); | ^~ vim +1236 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 1196 1197 1198 /** 1199 * vmw_du_connector_destroy_state - destroy connector state 1200 * @connector: DRM connector 1201 * @state: state object to destroy 1202 * 1203 * Destroys the connector state (both common and vmw-specific) for the 1204 * specified plane. 1205 */ 1206 void 1207 vmw_du_connector_destroy_state(struct drm_connector *connector, 1208 struct drm_connector_state *state) 1209 { 1210 drm_atomic_helper_connector_destroy_state(connector, state); 1211 } 1212 /* 1213 * Generic framebuffer code 1214 */ 1215 1216 /* 1217 * Surface framebuffer code 1218 */ 1219 1220 static void vmw_framebuffer_surface_destroy(struct drm_framebuffer *framebuffer) 1221 { 1222 struct vmw_framebuffer_surface *vfbs = 1223 vmw_framebuffer_to_vfbs(framebuffer); 1224 struct vmw_bo *bo = vmw_user_object_buffer(&vfbs->uo); 1225 struct vmw_surface *surf = vmw_user_object_surface(&vfbs->uo); 1226 1227 if (bo) { 1228 vmw_bo_dirty_release(bo); 1229 /* 1230 * bo->dirty is reference counted so it being NULL 1231 * means that the surface wasn't coherent to begin 1232 * with and so we have to free the dirty tracker 1233 * in the vmw_resource 1234 */ 1235 if (!bo->dirty && surf && surf->res.dirty) > 1236 surf->res.func->dirty_free(&surf->res); 1237 } 1238 drm_framebuffer_cleanup(framebuffer); 1239 vmw_user_object_unref(&vfbs->uo); 1240 1241 kfree(vfbs); 1242 } 1243 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki