From: Minda Chen <minda.chen@starfivetech.com>
To: Marek Vasut <marex@denx.de>, Tom Rini <trini@konsulko.com>,
Roger Quadros <rogerq@kernel.org>, Rick Chen <rick@andestech.com>,
Leo <ycliang@andestech.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Alexey Romanov <avromanov@salutedevices.com>,
Sumit Garg <sumit.garg@linaro.org>,
Mark Kettenis <kettenis@openbsd.org>, Nishanth Menon <nm@ti.com>
Cc: u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
Simon Glass <sjg@chromium.org>, E Shattow <lucent@gmail.com>,
Minda Chen <minda.chen@starfivetech.com>
Subject: [PATCH v7 1/8] usb: cdns3: Set USB PHY mode in cdns3_drd_update_mode()
Date: Thu, 6 Mar 2025 14:20:25 +0800 [thread overview]
Message-ID: <20250306062032.50314-2-minda.chen@starfivetech.com> (raw)
In-Reply-To: <20250306062032.50314-1-minda.chen@starfivetech.com>
USB PHY maybe need to set PHY mode in different USB
dr mode. So translate USB PHY mode to generic PHY mode
and call generic_phy_set_mode().
Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
Reviewed-by: Marek Vasut <marex@denx.de>
---
drivers/usb/cdns3/drd.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
index 47874fec29e..cbb13342343 100644
--- a/drivers/usb/cdns3/drd.c
+++ b/drivers/usb/cdns3/drd.c
@@ -217,15 +217,19 @@ static int cdns3_init_otg_mode(struct cdns3 *cdns)
int cdns3_drd_update_mode(struct cdns3 *cdns)
{
int ret = 0;
+ int mode;
switch (cdns->dr_mode) {
case USB_DR_MODE_PERIPHERAL:
+ mode = PHY_MODE_USB_DEVICE;
ret = cdns3_set_mode(cdns, USB_DR_MODE_PERIPHERAL);
break;
case USB_DR_MODE_HOST:
+ mode = PHY_MODE_USB_HOST;
ret = cdns3_set_mode(cdns, USB_DR_MODE_HOST);
break;
case USB_DR_MODE_OTG:
+ mode = PHY_MODE_USB_OTG;
ret = cdns3_init_otg_mode(cdns);
break;
default:
@@ -234,6 +238,16 @@ int cdns3_drd_update_mode(struct cdns3 *cdns)
return -EINVAL;
}
+ ret = generic_phy_set_mode(&cdns->usb2_phy, mode, 0);
+ if (ret) {
+ dev_err(cdns->dev, "Set usb 2.0 PHY mode failed %d\n", ret);
+ return ret;
+ }
+
+ ret = generic_phy_set_mode(&cdns->usb3_phy, mode, 0);
+ if (ret)
+ dev_err(cdns->dev, "Set usb 3.0 PHY mode failed %d\n", ret);
+
return ret;
}
--
2.17.1
next prev parent reply other threads:[~2025-03-06 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 6:20 [PATCH v7 0/8] Add Starfive JH7110 Cadence USB driver Minda Chen
2025-03-06 6:20 ` Minda Chen [this message]
2025-03-06 6:20 ` [PATCH v7 2/8] phy: starfive: Add Starfive JH7110 USB 2.0 PHY driver Minda Chen
2025-03-06 6:20 ` [PATCH v7 3/8] phy: starfive: Add Starfive JH7110 PCIe " Minda Chen
2025-03-06 6:20 ` [PATCH v7 4/8] usb: cdns: starfive: Get dr mode from wrapper device dts node Minda Chen
2025-03-06 6:20 ` [PATCH v7 5/8] usb: cdns: starfive: Add cdns USB driver Minda Chen
2025-03-06 6:20 ` [PATCH v7 6/8] spl: starfive: visionfive2: Disable USB overcurrent pin by default Minda Chen
2025-03-06 6:20 ` [PATCH v7 7/8] configs: starfive: Add visionfive2 cadence USB configuration Minda Chen
2025-03-06 6:20 ` [PATCH v7 8/8] MAINTAINERS: Update Starfive visionfive2 maintain files Minda Chen
2025-03-17 3:21 ` [PATCH v7 0/8] Add Starfive JH7110 Cadence USB driver Marek Vasut
2025-03-17 6:09 ` Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306062032.50314-2-minda.chen@starfivetech.com \
--to=minda.chen@starfivetech.com \
--cc=avromanov@salutedevices.com \
--cc=kettenis@openbsd.org \
--cc=lucent@gmail.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=rick@andestech.com \
--cc=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=sumit.garg@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.