From: kernel test robot <lkp@intel.com>
To: Sricharan R <quic_srichara@quicinc.com>,
jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andersson@kernel.org, konradybcio@kernel.org,
manivannan.sadhasivam@linaro.org, dmitry.baryshkov@linaro.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver
Date: Thu, 6 Mar 2025 15:53:38 +0800 [thread overview]
Message-ID: <202503061517.ZTyZF7qx-lkp@intel.com> (raw)
In-Reply-To: <20250228045356.3527662-3-quic_srichara@quicinc.com>
Hi Sricharan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.14-rc5 next-20250305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sricharan-R/dt-bindings-mailbox-Document-qcom-tmel-qmp/20250228-125707
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250228045356.3527662-3-quic_srichara%40quicinc.com
patch subject: [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20250306/202503061517.ZTyZF7qx-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250306/202503061517.ZTyZF7qx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503061517.ZTyZF7qx-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/dma-mapping.h:5,
from drivers/mailbox/qcom-tmel-qmp.c:6:
drivers/mailbox/qcom-tmel-qmp.c: In function 'qmp_send_data':
>> drivers/mailbox/qcom-tmel-qmp.c:196:36: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
196 | dev_err(mdev->dev, "Unsupported packet size %ld\n", pkt->iov_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/mailbox/qcom-tmel-qmp.c:196:17: note: in expansion of macro 'dev_err'
196 | dev_err(mdev->dev, "Unsupported packet size %ld\n", pkt->iov_len);
| ^~~~~~~
drivers/mailbox/qcom-tmel-qmp.c:196:63: note: format string is defined here
196 | dev_err(mdev->dev, "Unsupported packet size %ld\n", pkt->iov_len);
| ~~^
| |
| long int
| %d
In file included from drivers/mailbox/qcom-tmel-qmp.c:10:
drivers/mailbox/qcom-tmel-qmp.c: In function 'tmel_prepare_msg':
include/linux/mailbox/tmelcom-qmp.h:16:41: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
16 | #define TMEL_MSG_UID_MSG_TYPE(v) FIELD_GET(GENMASK(15, 8), v)
| ^~~~~~~~~
drivers/mailbox/qcom-tmel-qmp.c:406:29: note: in expansion of macro 'TMEL_MSG_UID_MSG_TYPE'
406 | msg_hdr->msg_type = TMEL_MSG_UID_MSG_TYPE(msg_uid);
| ^~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/qcom-tmel-qmp.c: In function 'tmel_process_request':
drivers/mailbox/qcom-tmel-qmp.c:501:36: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
501 | dev_err(tdev->dev, "Invalid pkt.size received size: %ld, expected: %zu\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/mailbox/qcom-tmel-qmp.c:501:17: note: in expansion of macro 'dev_err'
501 | dev_err(tdev->dev, "Invalid pkt.size received size: %ld, expected: %zu\n",
| ^~~~~~~
drivers/mailbox/qcom-tmel-qmp.c:501:71: note: format string is defined here
501 | dev_err(tdev->dev, "Invalid pkt.size received size: %ld, expected: %zu\n",
| ~~^
| |
| long int
| %d
drivers/mailbox/qcom-tmel-qmp.c: In function 'tmel_secboot_sec_auth':
include/linux/mailbox/tmelcom-qmp.h:13:10: error: implicit declaration of function 'FIELD_PREP_CONST' [-Wimplicit-function-declaration]
13 | (FIELD_PREP_CONST((0xff << 8), msg_type) | FIELD_PREP_CONST(0xff, action_id))
| ^~~~~~~~~~~~~~~~
include/linux/mailbox/tmelcom-qmp.h:55:45: note: in expansion of macro 'TMEL_MSG_UID_CREATE'
55 | #define TMEL_MSG_UID_SECBOOT_SEC_AUTH TMEL_MSG_UID_CREATE(TMEL_MSG_SECBOOT,\
| ^~~~~~~~~~~~~~~~~~~
drivers/mailbox/qcom-tmel-qmp.c:541:42: note: in expansion of macro 'TMEL_MSG_UID_SECBOOT_SEC_AUTH'
541 | ret = tmel_process_request(tdev, TMEL_MSG_UID_SECBOOT_SEC_AUTH, msg,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/qcom-tmel-qmp.c: In function 'tmel_qmp_send_work':
drivers/mailbox/qcom-tmel-qmp.c:595:9: error: case label does not reduce to an integer constant
595 | case TMEL_MSG_UID_SECBOOT_SEC_AUTH:
| ^~~~
drivers/mailbox/qcom-tmel-qmp.c:598:9: error: case label does not reduce to an integer constant
598 | case TMEL_MSG_UID_SECBOOT_SS_TEAR_DOWN:
| ^~~~
vim +196 drivers/mailbox/qcom-tmel-qmp.c
177
178 /**
179 * qmp_send_data() - Copy the data to the channel's mailbox and notify
180 * remote subsystem of new data. This function will
181 * return an error if the previous message sent has
182 * not been read. Cannot Sleep.
183 * @mdev: qmp_device to send the data to.
184 * @data: Data to be sent to remote processor, should be in the format of
185 * a kvec.
186 *
187 * Return: 0 on success or standard Linux error code.
188 */
189 static int qmp_send_data(struct qmp_device *mdev, void *data)
190 {
191 struct kvec *pkt = (struct kvec *)data;
192 void __iomem *addr;
193 unsigned long flags;
194
195 if (pkt->iov_len > QMP_MAX_PKT_SIZE) {
> 196 dev_err(mdev->dev, "Unsupported packet size %ld\n", pkt->iov_len);
197 return -EINVAL;
198 }
199
200 if (atomic_read(&mdev->tx_sent))
201 return -EAGAIN;
202
203 dev_dbg(mdev->dev, "%s: mcore 0x%x ucore 0x%x", __func__,
204 mdev->mcore.val, mdev->ucore.val);
205
206 addr = mdev->mcore_desc + QMP_CTRL_DATA_SIZE;
207 memcpy_toio(addr, pkt->iov_base, pkt->iov_len);
208
209 mdev->mcore.bits.frag_size = pkt->iov_len;
210 mdev->mcore.bits.rem_frag_count = 0;
211
212 dev_dbg(mdev->dev, "Copied buffer to mbox, sz: %d",
213 mdev->mcore.bits.frag_size);
214
215 atomic_set(&mdev->tx_sent, 1);
216
217 spin_lock_irqsave(&mdev->tx_lock, flags);
218 mdev->mcore.bits.tx = !(mdev->mcore.bits.tx);
219 qmp_send_irq(mdev);
220 spin_unlock_irqrestore(&mdev->tx_lock, flags);
221
222 return 0;
223 }
224
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-03-06 7:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 4:53 [PATCH V3 0/2] mailbox: tmel-qmp: Introduce QCOM TMEL QMP mailbox driver Sricharan R
2025-02-28 4:53 ` [PATCH V3 1/2] dt-bindings: mailbox: Document qcom,tmel-qmp Sricharan R
2025-02-28 6:06 ` Dmitry Baryshkov
2025-03-03 7:21 ` Sricharan Ramabadhran
2025-03-03 13:03 ` Dmitry Baryshkov
2025-03-04 8:57 ` Sricharan Ramabadhran
2025-02-28 4:53 ` [PATCH V3 2/2] mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver Sricharan R
2025-02-28 6:33 ` Dmitry Baryshkov
2025-03-03 10:28 ` Sricharan Ramabadhran
2025-03-03 13:04 ` Dmitry Baryshkov
2025-03-04 9:33 ` Sricharan Ramabadhran
2025-03-04 9:46 ` Dmitry Baryshkov
2025-03-04 16:46 ` Konrad Dybcio
2025-03-05 7:33 ` Sricharan Ramabadhran
2025-03-05 6:12 ` Sricharan Ramabadhran
2025-03-06 0:26 ` kernel test robot
2025-03-06 7:53 ` kernel test robot [this message]
2025-03-06 17:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503061517.ZTyZF7qx-lkp@intel.com \
--to=lkp@intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_srichara@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.