From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6425213D89D; Fri, 7 Mar 2025 01:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741309931; cv=none; b=Nv5MSQs1oKW433uzyZi+jwcbxK8b29U85LbflSJjT+E/Dki/MqCjhinCZzWNWT2m+1nDjyue2MmGGd1TNUZv3A8PRWKP17XmWN/4pOZmBbmHoOP4jF6GBBJ+aI+jjqiAueYm2GCBWPk4NYt9cucq5xYKm7I2HzNsjwqo1VP4aMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741309931; c=relaxed/simple; bh=iAkkgLRwGib7vQ+FD30A942Pd09V5NCtDsEeMhpAUqM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SvQe3JOIPxxJ+AWIHFfwMObQzuCCK1FVRO1icHmXpRsTPpxue2PdCKGjdYGwhswiTwmr8M2KEdLAxeC+5inW7/IJkUfgujKiWV2/JgcVChBcs1NPLajwH3t3OqnF7AiWqES2NUdSe8xJwhVD1apUdGRBhrmaBqooJpHcpafPdD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M45pXKE9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M45pXKE9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 030B9C4CEE0; Fri, 7 Mar 2025 01:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741309929; bh=iAkkgLRwGib7vQ+FD30A942Pd09V5NCtDsEeMhpAUqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M45pXKE9zkU9gssiyoTXRtcCF8zxbGnEPxAzZgZxm2OqPKSreW0X3H5MGGZLMMfHK OStf429IO4RVa+Qkqg54dpGCfKVeYYobcgRrckZsKfbuASUxX0OTzSOfL9jEDJ4djg ndQWb8LBx9QltWQZlFB6VM83sQmBC163rVLR7DIGuhcHqf2LE4F8IIU3C/DCIUWOhT KqMzL1REFctMOmR7oJ/4JyRqaH0bjzCgFsDFm4YrIhhTL2G9TYZtz9utBUorEfddfw O9D16dCJHua+bv9bvT0tWtvLVHJ/FqnHTwip6ANCaUK47B8nTiiqEI4OFUTddfWPYb tlIA+06s+XYMg== Date: Thu, 6 Mar 2025 17:12:08 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: intel-wired-lan@lists.osuosl.org, Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Simon Horman , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 11/16] idpf: prepare structures to support XDP Message-ID: <20250306171208.3162eb97@kernel.org> In-Reply-To: <20250305162132.1106080-12-aleksander.lobakin@intel.com> References: <20250305162132.1106080-1-aleksander.lobakin@intel.com> <20250305162132.1106080-12-aleksander.lobakin@intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 5 Mar 2025 17:21:27 +0100 Alexander Lobakin wrote: > +/** > + * idpf_xdp_is_prog_ena - check if there is an XDP program on adapter > + * @vport: vport to check > + */ > +static inline bool idpf_xdp_is_prog_ena(const struct idpf_vport *vport) > +{ > + return vport->adapter && vport->xdp_prog; > +} drivers/net/ethernet/intel/idpf/idpf.h:624: warning: No description found for return value of 'idpf_xdp_is_prog_ena' The documentation doesn't add much info, just remove it ? -- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25A2FC282D1 for ; Fri, 7 Mar 2025 01:12:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C847E810B5; Fri, 7 Mar 2025 01:12:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yD-sK8UmJDx5; Fri, 7 Mar 2025 01:12:13 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4499A810E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1741309933; bh=5as/oUsfQDFNY9drlpvLyiS9Fg8LsD2uUlqSDPJeheU=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=7q9+aw4cWpq4tTgrlJC4wZNqP4diZ9moUxcTlFnBHQ3MW2PkyNbBtaGHP9t0jFtzt 8I0lQcPA8eIyBpmPTILjmK9+yr61zok0is4lr1nJmPtJKNWqqjKMO3K/jBLUSU7PWq Up9FPO4gix6pSMaxK2NY/NCj2MYTyaJeE9gFEJOhl44JGk5nxsnDY2lOOWxPaW9Dg4 yLiHwxHng5Y3LymuATeybBiAUIYPj5uED7pamNtA+jgNJ+a1WjxXxD1LSr8nobV3P9 Lh8twhjrJO3X6ExyXp48LFSI3mjhTGCsS6e4KsdA/73PuFZYZvXGomqHgOfKBJhJ5V UGCdx3qpTpSPg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 4499A810E6; Fri, 7 Mar 2025 01:12:13 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 5284071F for ; Fri, 7 Mar 2025 01:12:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 36BEE412C4 for ; Fri, 7 Mar 2025 01:12:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id pwMu0Yuq97M2 for ; Fri, 7 Mar 2025 01:12:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7651B412FF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7651B412FF Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7651B412FF for ; Fri, 7 Mar 2025 01:12:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8A311A4538C; Fri, 7 Mar 2025 01:06:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 030B9C4CEE0; Fri, 7 Mar 2025 01:12:08 +0000 (UTC) Date: Thu, 6 Mar 2025 17:12:08 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: intel-wired-lan@lists.osuosl.org, Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Simon Horman , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20250306171208.3162eb97@kernel.org> In-Reply-To: <20250305162132.1106080-12-aleksander.lobakin@intel.com> References: <20250305162132.1106080-1-aleksander.lobakin@intel.com> <20250305162132.1106080-12-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741309929; bh=iAkkgLRwGib7vQ+FD30A942Pd09V5NCtDsEeMhpAUqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M45pXKE9zkU9gssiyoTXRtcCF8zxbGnEPxAzZgZxm2OqPKSreW0X3H5MGGZLMMfHK OStf429IO4RVa+Qkqg54dpGCfKVeYYobcgRrckZsKfbuASUxX0OTzSOfL9jEDJ4djg ndQWb8LBx9QltWQZlFB6VM83sQmBC163rVLR7DIGuhcHqf2LE4F8IIU3C/DCIUWOhT KqMzL1REFctMOmR7oJ/4JyRqaH0bjzCgFsDFm4YrIhhTL2G9TYZtz9utBUorEfddfw O9D16dCJHua+bv9bvT0tWtvLVHJ/FqnHTwip6ANCaUK47B8nTiiqEI4OFUTddfWPYb tlIA+06s+XYMg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=M45pXKE9 Subject: Re: [Intel-wired-lan] [PATCH net-next 11/16] idpf: prepare structures to support XDP X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 5 Mar 2025 17:21:27 +0100 Alexander Lobakin wrote: > +/** > + * idpf_xdp_is_prog_ena - check if there is an XDP program on adapter > + * @vport: vport to check > + */ > +static inline bool idpf_xdp_is_prog_ena(const struct idpf_vport *vport) > +{ > + return vport->adapter && vport->xdp_prog; > +} drivers/net/ethernet/intel/idpf/idpf.h:624: warning: No description found for return value of 'idpf_xdp_is_prog_ena' The documentation doesn't add much info, just remove it ? -- pw-bot: cr