From: Sam Winchenbach <sam.winchenbach@framepointer.org>
To: linux-kernel@vger.kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
antoniu.miclaus@analog.com, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
sam.winchenbach@framepointer.org, bpellegrino@arka.org
Subject: [PATCH v5 3/6] iio: filter: admv8818: fix integer overflow
Date: Thu, 6 Mar 2025 13:33:11 -0500 [thread overview]
Message-ID: <20250306183314.150253-3-sam.winchenbach@framepointer.org> (raw)
In-Reply-To: <20250306183314.150253-1-sam.winchenbach@framepointer.org>
HZ_PER_MHZ is only unsigned long. This math overflows, leading to
incorrect results.
Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
Signed-off-by: Sam Winchenbach <sam.winchenbach@framepointer.org>
---
drivers/iio/filter/admv8818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c
index 8f563a426232..a059282e0251 100644
--- a/drivers/iio/filter/admv8818.c
+++ b/drivers/iio/filter/admv8818.c
@@ -154,7 +154,7 @@ static int __admv8818_hpf_select(struct admv8818_state *st, u64 freq)
}
/* Close HPF frequency gap between 12 and 12.5 GHz */
- if (freq >= 12000 * HZ_PER_MHZ && freq <= 12500 * HZ_PER_MHZ) {
+ if (freq >= 12000ULL * HZ_PER_MHZ && freq < 12500ULL * HZ_PER_MHZ) {
hpf_band = 3;
hpf_step = 15;
}
--
2.48.1
next prev parent reply other threads:[~2025-03-06 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 18:33 [PATCH v5 1/6] dt-bindings: iio: filter: Add lpf/hpf freq margins Sam Winchenbach
2025-03-06 18:33 ` [PATCH v5 2/6] iio: filter: admv8818: fix band 4, state 15 Sam Winchenbach
2025-03-06 18:33 ` Sam Winchenbach [this message]
2025-03-06 18:33 ` [PATCH v5 4/6] iio: filter: admv8818: fix range calculation Sam Winchenbach
2025-03-06 19:05 ` [PATCH 5/6] driver core: Add support for writing 64 bit attrs Sam Winchenbach
2025-03-06 19:05 ` [PATCH 6/6] iio: filter: admv8818: Support frequencies >= 2^32 Sam Winchenbach
2025-03-07 8:34 ` [PATCH v5 1/6] dt-bindings: iio: filter: Add lpf/hpf freq margins Krzysztof Kozlowski
2025-03-07 13:47 ` Sam Winchenbach
2025-03-09 19:55 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306183314.150253-3-sam.winchenbach@framepointer.org \
--to=sam.winchenbach@framepointer.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=bpellegrino@arka.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.