From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780F5C282D1 for ; Thu, 6 Mar 2025 19:53:53 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web11.3829.1741290828745004036 for ; Thu, 06 Mar 2025 11:53:49 -0800 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id D8D9D40C2E; Thu, 6 Mar 2025 19:53:47 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HEPgKCP14Moy; Thu, 6 Mar 2025 19:53:47 +0000 (UTC) Received: from mail.denix.org (pool-100-15-87-159.washdc.fios.verizon.net [100.15.87.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 9AA0A40B66; Thu, 6 Mar 2025 19:53:43 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 5A9071642DE; Thu, 6 Mar 2025 14:53:43 -0500 (EST) Date: Thu, 6 Mar 2025 14:53:43 -0500 From: Denys Dmytriyenko To: a-christidis@ti.com Cc: Andrew Davis , meta-arago@lists.yoctoproject.org, Ryan Eatmon , rs@ti.com Subject: Re: [meta-arago][scarthgap/master][PATCH v2] ti-gc320-tests: Add RDEPENDS ti-gc320-libs-dev Message-ID: <20250306195343.GO1879@denix.org> References: <20250306000441.408976-1-a-christidis@ti.com> <86cd4026-810e-49e1-8fc3-145014c14e2e@ti.com> <84408d91-3248-4366-b440-3d715badf112@ti.com> <6c0b1077-e996-41bb-8061-24fee82da4f4@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Content-Transfer-Encoding: quoted-printable List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 06 Mar 2025 19:53:53 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/15958 On Thu, Mar 06, 2025 at 12:50:56PM -0600, Antonios Christidis via lists.y= octoproject.org wrote: >=20 > On 3/6/25 11:35 AM, Andrew Davis wrote: > >On 3/6/25 11:29 AM, Antonios Christidis wrote: > >> > >>On 3/6/25 11:25 AM, Andrew Davis wrote: > >>>On 3/6/25 11:09 AM, Antonios Christidis wrote: > >>>> > >>>>On 3/6/25 10:57 AM, Andrew Davis wrote: > >>>>>On 3/6/25 10:03 AM, Antonios Christidis wrote: > >>>>>> > >>>>>>On 3/6/25 7:32 AM, Andrew Davis wrote: > >>>>>>>On 3/5/25 6:04 PM, a-christidis@ti.com wrote: > >>>>>>>>From: Antonios Christidis > >>>>>>>> > >>>>>>>>Include the package ti-gc320-libs-dev as a runtime dependency. > >>>>>>>> > >>>>>>>>Signed-off-by: Antonios Christidis > >>>>>>>>--- > >>>>>>>> > >>>>>>>>v2: > >>>>>>>>- Added dev-deps on INSANE_SKIP > >>>>>>>> > >>>>>>>>=A0 .../ti-gc320-tests/ti-gc320-tests_5.0.11.p7.bb | 3 ++- > >>>>>>>>=A0 1 file changed, 2 insertions(+), 1 deletion(-) > >>>>>>>> > >>>>>>>>diff --git a/meta-arago-extras/recipes-graphics/ti-gc320-tests/= ti-gc320-tests_5.0.11.p7.bb b/meta-arago-extras/recipes-graphics/ti-gc320= -tests/ti-gc320-tests_5.0.11.p7.bb > >>>>>>>> > >>>>>>>>index f9b9685f..14278d76 100644 > >>>>>>>>--- a/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc32= 0-tests_5.0.11.p7.bb > >>>>>>>>+++ b/meta-arago-extras/recipes-graphics/ti-gc320-tests/ti-gc32= 0-tests_5.0.11.p7.bb > >>>>>>>>@@ -4,6 +4,7 @@ LICENSE =3D "MIT" > >>>>>>>>=A0 LIC_FILES_CHKSUM =3D "file://dra7x-sdk-ti-gc320-tests_manif= est.html;md5=3D22a001855467f373c47f45de5330e3c9" > >>>>>>>>=A0 =A0 DEPENDS =3D "ti-gc320-libs" > >>>>>>>>+RDEPENDS:${PN}:append =3D " ti-gc320-libs-dev" > >>>>>>> > >>>>>>>This should be detected and set for you based on DEPENDS. You do= n't > >>>>>>>need any change here. > >>>>>>> > >>>>>>>Andrew > >>>>>>> > >>>>>>The way DEPENDS is setup it will not include > >>>>>>ti-gc320-libs-dev package in the fs. > >>>>>> > >>>>>>=A0=A0The contents of the -dev package are required at > >>>>>>runtime for the gc320 tests. > >>>>>> > >>>>> > >>>>>Why? What is going into the dev package that is needed by the test= s? > >>>>> > >>>>>Andrew > >>>>> > >>>>libGAL.so symb link. > >>> > >>>If users of this library are meant to dlopen() that file, then > >>>add it to the > >>>regular ti-gc320-libs package. > >>> > >>> > >>I did that in [1]. However, Denys let me know symb link should > >>go in the -dev package. > >> > > > >For header files I'd agree, and usually for .so files. But in this > >case if > >the users of this need this file (as in it is not just used for > >compiling) > >then it can go in the base package. We do this for instance with > >GStreamer > >plugins[0]. > > > I prefer the above option. Ryan, Denys, Randolph what do you think ? 1. Is libGAL.so a symlink to a versioned libGAL.so.X.Y.Z or libGAL.so.X=20 library? 2. Does it get linked during compile time, like a regular shared library,= =20 or is it meant to be dlopen()-ed? If it's a regular shared library and .so is a symlink to a versioned copy= ,=20 then .so should go into -dev package and you don't pull that package into= =20 a rootfs, unless you want to enable on-target development. If it's a regular shared library that gets linked at build time, but ther= e's=20 no versioned copies produced, as .so is the only output, then the best op= tion=20 os to fix your build to produce versioned copies and .so synlink. Alterna= tive,=20 but less desirable option, is to put .so library (not synlink) into the m= ain=20 package, like Andrew mentioned. If this .so is meant to be dlopen() at runtime, then it should not be a=20 symlink, first of all, but then you also want to move it into the main=20 package. Also, you don't pull header files into the main package[1], even if you n= eed=20 to enable on-target development - you use -dev package along with other=20 tools. Normally you enable that with "dev-pkgs" in IMAGE_FEATURES or glob= ally=20 in EXTRA_IMAGE_FEATURES. And lastly - you don't ever want to try to pull even a single -dev packag= e=20 explicitly via RDEPENDS, because it will trigger a chain reaction for man= y=20 other -dev packages, so it will blow up your dependency tree. I already=20 explained it here: https://lists.yoctoproject.org/g/meta-arago/message/15696 > >Another option is to fix up the tests so they link with libGAL the > >normal way.. > > > >[0] https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/rec= ipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-hevc_git.bb?h=3Dscart= hgap#n32 > > > >>[1] =3D https://patchwork.yoctoproject.org/project/ti/patch/202502122= 01830.2090247-3-a-christidis@ti.com/