Re: [PATCH v5 06/11] misc: amd-sbi: Add support for AMD_SBI IOCTL

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250303105902.215009-7-akshay.gupta@amd.com>
References: <20250303105902.215009-7-akshay.gupta@amd.com>
TO: Akshay Gupta <akshay.gupta@amd.com>
TO: linux-hwmon@vger.kernel.org
TO: linux-kernel@vger.kernel.org
CC: linux@roeck-us.net
CC: gregkh@linuxfoundation.org
CC: arnd@arndb.de
CC: shyam-sundar.s-k@amd.com
CC: gautham.shenoy@amd.com
CC: mario.limonciello@amd.com
CC: naveenkrishna.chatradhi@amd.com
CC: Akshay Gupta <akshay.gupta@amd.com>

Hi Akshay,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus groeck-staging/hwmon-next soc/for-next linus/master v6.14-rc5 next-20250306]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Akshay-Gupta/hwmon-misc-amd-sbi-Move-core-sbrmi-from-hwmon-to-misc/20250303-190830
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20250303105902.215009-7-akshay.gupta%40amd.com
patch subject: [PATCH v5 06/11] misc: amd-sbi: Add support for AMD_SBI IOCTL
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: riscv-randconfig-r072-20250306 (https://download.01.org/0day-ci/archive/20250307/202503071145.fhmAEjMr-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202503071145.fhmAEjMr-lkp@intel.com/

smatch warnings:
drivers/misc/amd-sbi/rmi-core.c:110 sbrmi_ioctl() warn: can 'data' even be NULL?

vim +/data +110 drivers/misc/amd-sbi/rmi-core.c

dd49a6be4bc20c Akshay Gupta 2025-03-03  100  
dd49a6be4bc20c Akshay Gupta 2025-03-03  101  static long sbrmi_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
dd49a6be4bc20c Akshay Gupta 2025-03-03  102  {
dd49a6be4bc20c Akshay Gupta 2025-03-03  103  	int __user *arguser = (int  __user *)arg;
dd49a6be4bc20c Akshay Gupta 2025-03-03  104  	struct apml_message msg = { 0 };
dd49a6be4bc20c Akshay Gupta 2025-03-03  105  	bool read = false;
dd49a6be4bc20c Akshay Gupta 2025-03-03  106  	int ret;
dd49a6be4bc20c Akshay Gupta 2025-03-03  107  
dd49a6be4bc20c Akshay Gupta 2025-03-03  108  	struct sbrmi_data *data = container_of(fp->private_data, struct sbrmi_data,
dd49a6be4bc20c Akshay Gupta 2025-03-03  109  					       sbrmi_misc_dev);
dd49a6be4bc20c Akshay Gupta 2025-03-03 @110  	if (!data)
dd49a6be4bc20c Akshay Gupta 2025-03-03  111  		return -ENODEV;
dd49a6be4bc20c Akshay Gupta 2025-03-03  112  
dd49a6be4bc20c Akshay Gupta 2025-03-03  113  	/* Copy the structure from user */
dd49a6be4bc20c Akshay Gupta 2025-03-03  114  	if (copy_struct_from_user(&msg, sizeof(msg), arguser,
dd49a6be4bc20c Akshay Gupta 2025-03-03  115  				  sizeof(struct apml_message)))
dd49a6be4bc20c Akshay Gupta 2025-03-03  116  		return -EFAULT;
dd49a6be4bc20c Akshay Gupta 2025-03-03  117  
dd49a6be4bc20c Akshay Gupta 2025-03-03  118  	/* Is this a read/monitor/get request */
dd49a6be4bc20c Akshay Gupta 2025-03-03  119  	if (msg.data_in.reg_in[AMD_SBI_RD_FLAG_INDEX])
dd49a6be4bc20c Akshay Gupta 2025-03-03  120  		read = true;
dd49a6be4bc20c Akshay Gupta 2025-03-03  121  
dd49a6be4bc20c Akshay Gupta 2025-03-03  122  	switch (msg.cmd) {
dd49a6be4bc20c Akshay Gupta 2025-03-03  123  	case 0 ... 0x999:
dd49a6be4bc20c Akshay Gupta 2025-03-03  124  		/* Mailbox protocol */
dd49a6be4bc20c Akshay Gupta 2025-03-03  125  		ret = rmi_mailbox_xfer(data, &msg);
dd49a6be4bc20c Akshay Gupta 2025-03-03  126  		break;
dd49a6be4bc20c Akshay Gupta 2025-03-03  127  	default:
dd49a6be4bc20c Akshay Gupta 2025-03-03  128  		return -EINVAL;
dd49a6be4bc20c Akshay Gupta 2025-03-03  129  	}
dd49a6be4bc20c Akshay Gupta 2025-03-03  130  
dd49a6be4bc20c Akshay Gupta 2025-03-03  131  	/* Copy results back to user only for get/monitor commands and firmware failures */
dd49a6be4bc20c Akshay Gupta 2025-03-03  132  	if ((read && !ret) || ret == -EPROTOTYPE) {
dd49a6be4bc20c Akshay Gupta 2025-03-03  133  		if (copy_to_user(arguser, &msg, sizeof(struct apml_message)))
dd49a6be4bc20c Akshay Gupta 2025-03-03  134  			ret = -EFAULT;
dd49a6be4bc20c Akshay Gupta 2025-03-03  135  	}
dd49a6be4bc20c Akshay Gupta 2025-03-03  136  	return ret;
dd49a6be4bc20c Akshay Gupta 2025-03-03  137  }
dd49a6be4bc20c Akshay Gupta 2025-03-03  138  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki