From: Al Viro <viro@zeniv.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org,
Kent Overstreet <kent.overstreet@linux.dev>
Subject: Re: [PATCH] vfs: Remove invalidate_inodes()
Date: Fri, 7 Mar 2025 20:01:07 +0000 [thread overview]
Message-ID: <20250307200107.GJ2023217@ZenIV> (raw)
In-Reply-To: <20250307144318.28120-2-jack@suse.cz>
On Fri, Mar 07, 2025 at 03:43:19PM +0100, Jan Kara wrote:
> The function is exactly the same as evict_inodes() and has only one
> user.
<pedantic>
nearly the same - evict_inodes() skips the inodes with positive
refcount without touching ->i_lock, but they are equivalent (evict_inodes()
repeats the refcount check after having grabbed ->i_lock).
</pedantic>
ACK, except that it might make sense to add a note in D/f/porting.rst -
or just add #defined invalidate_inodes evict_inodes for this cycle
and remove it (with obvious note in D/f/porting.rst) in the next one.
next prev parent reply other threads:[~2025-03-07 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 14:43 [PATCH] vfs: Remove invalidate_inodes() Jan Kara
2025-03-07 20:01 ` Al Viro [this message]
2025-03-08 11:21 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307200107.GJ2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.