From: Kees Cook <kees@kernel.org>
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
ebiederm@xmission.com, sunliming@linux.dev,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, sunliming@kylinos.cn,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used warning
Date: Fri, 7 Mar 2025 20:07:01 -0800 [thread overview]
Message-ID: <202503072006.B920348F@keescook> (raw)
In-Reply-To: <CAKbZUD1ieaVVD9A9CG=5oCacud4JqnxzYgMv=fiQK=2zT_y10w@mail.gmail.com>
On Sat, Mar 08, 2025 at 04:01:50AM +0000, Pedro Falcato wrote:
> On Sat, Mar 8, 2025 at 3:45 AM Kees Cook <kees@kernel.org> wrote:
> >
> > On Sat, 08 Mar 2025 10:27:54 +0800, sunliming@linux.dev wrote:
> > > Fix below kernel warning:
> > > fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not
> > > used [-Wunused-but-set-variable]
> > >
> > >
> >
> > Adjusted Subject for typos.
> >
> > Applied to for-next/execve, thanks!
> >
> > [1/1] binfmt_elf_fdpic: fix variable set but not used warning
> > https://git.kernel.org/kees/c/7845fe65b33d
> >
>
> FYI, there's a typo so this patch won't compile
>
> >+ unsiged long excess1
> >+ = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK);
>
> s/unsiged/unsigned/
D'oh. Fixing in my tree..
--
Kees Cook
prev parent reply other threads:[~2025-03-08 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 2:27 [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used warning sunliming
2025-03-08 3:42 ` Kees Cook
2025-03-08 4:01 ` Pedro Falcato
2025-03-08 4:07 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503072006.B920348F@keescook \
--to=kees@kernel.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=pedro.falcato@gmail.com \
--cc=sunliming@kylinos.cn \
--cc=sunliming@linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.