From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: [linux-next:master 7915/9634] drivers/acpi/button.c:456:2-3: Unneeded semicolon
Date: Sun, 9 Mar 2025 04:46:33 +0800 [thread overview]
Message-ID: <202503090406.aRfaZUA0-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 0a2f889128969dab41861b6e40111aa03dc57014
commit: 39bc24ceb09df1bd4c333a19bec0b021567cb03c [7915/9634] ACPI: button: Install notifier for system events as well
config: loongarch-randconfig-r052-20250308 (https://download.01.org/0day-ci/archive/20250309/202503090406.aRfaZUA0-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503090406.aRfaZUA0-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/acpi/button.c:456:2-3: Unneeded semicolon
vim +456 drivers/acpi/button.c
439
440 static void acpi_button_notify(acpi_handle handle, u32 event, void *data)
441 {
442 struct acpi_device *device = data;
443 struct acpi_button *button;
444 struct input_dev *input;
445 int keycode;
446
447 switch (event) {
448 case ACPI_BUTTON_NOTIFY_STATUS:
449 break;
450 case ACPI_BUTTON_NOTIFY_WAKE:
451 break;
452 default:
453 acpi_handle_debug(device->handle, "Unsupported event [0x%x]\n",
454 event);
455 return;
> 456 };
457
458 acpi_pm_wakeup_event(&device->dev);
459
460 button = acpi_driver_data(device);
461 if (button->suspended)
462 return;
463
464 input = button->input;
465 keycode = test_bit(KEY_SLEEP, input->keybit) ? KEY_SLEEP : KEY_POWER;
466
467 input_report_key(input, keycode, 1);
468 input_sync(input);
469 input_report_key(input, keycode, 0);
470 input_sync(input);
471
472 acpi_bus_generate_netlink_event(device->pnp.device_class,
473 dev_name(&device->dev),
474 event, ++button->pushed);
475 }
476
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-03-08 20:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503090406.aRfaZUA0-lkp@intel.com \
--to=lkp@intel.com \
--cc=mario.limonciello@amd.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.