Re: [PATCH stable v5.4 v2 1/3] overflow: Add __must_check attribute to check_*() helpers

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 9b80e4c4ddaca3501177ed41e49d0928ba2122a8

WARNING: Author mismatch between patch and upstream commit:
Backport author: Florian Fainelli<florian.fainelli@broadcom.com>
Commit author: Kees Cook<keescook@chromium.org>

Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)
6.1.y | Present (exact SHA1)

Note: The patch differs from the upstream commit:
---
1:  9b80e4c4ddaca ! 1:  0aad002281c33 overflow: Add __must_check attribute to check_*() helpers
    @@ Metadata
      ## Commit message ##
         overflow: Add __must_check attribute to check_*() helpers
     
    +    commit 9b80e4c4ddaca3501177ed41e49d0928ba2122a8 upstream
    +
         Since the destination variable of the check_*_overflow() helpers will
         contain a wrapped value on failure, it would be best to make sure callers
         really did check the return result of the helper. Adjust the macros to use
    @@ Commit message
         Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
         Link: https://lore.kernel.org/lkml/202008151007.EF679DF@keescook/
         Signed-off-by: Kees Cook <keescook@chromium.org>
    +    Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
     
      ## include/linux/overflow.h ##
     @@
    @@ include/linux/overflow.h
     +}))
      
      /**
    -  * array_size() - Calculate size of 2-dimensional array.
    +  * size_mul() - Calculate size_t multiplication with saturation at SIZE_MAX
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y        |  Success    |  Success   |