Re: [RFC PATCH v2 12/16] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers

[kernel test robot <lkp@intel.com>]

Hi Cosmin,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on staging/staging-testing staging/staging-next staging/staging-linus arm64/for-next/core linus/master v6.14-rc5 next-20250307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cosmin-Tanislav/dt-bindings-media-i2c-max96717-add-myself-as-maintainer/20250309-165419
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250309084814.3114794-13-demonsingur%40gmail.com
patch subject: [RFC PATCH v2 12/16] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers
config: x86_64-buildonly-randconfig-001-20250310 (https://download.01.org/0day-ci/archive/20250310/202503100343.rizlFiNm-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250310/202503100343.rizlFiNm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503100343.rizlFiNm-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/media/i2c/maxim-serdes/max96717.c: In function 'max96717_mux_set_rclkout':
>> drivers/media/i2c/maxim-serdes/max96717.c:663:34: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     663 |                                  FIELD_PREP(MAX96717_REF_VTG1_PCLK_GPIO, group));
         |                                  ^~~~~~~~~~
   cc1: some warnings being treated as errors
--
>> drivers/media/i2c/maxim-serdes/max_ser.c:218:10: error: 'const struct i2c_atr_ops' has no member named 'attach_addr'
     218 |         .attach_addr = max_ser_i2c_atr_attach_addr,
         |          ^~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:218:24: error: initialization of 'int (*)(struct i2c_atr *, u32,  const struct i2c_client *, u16)' {aka 'int (*)(struct i2c_atr *, unsigned int,  const struct i2c_client *, short unsigned int)'} from incompatible pointer type 'int (*)(struct i2c_atr *, u32,  u16,  u16)' {aka 'int (*)(struct i2c_atr *, unsigned int,  short unsigned int,  short unsigned int)'} [-Werror=incompatible-pointer-types]
     218 |         .attach_addr = max_ser_i2c_atr_attach_addr,
         |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/maxim-serdes/max_ser.c:218:24: note: (near initialization for 'max_ser_i2c_atr_ops.attach_client')
>> drivers/media/i2c/maxim-serdes/max_ser.c:219:10: error: 'const struct i2c_atr_ops' has no member named 'detach_addr'
     219 |         .detach_addr = max_ser_i2c_atr_detach_addr,
         |          ^~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:219:24: error: initialization of 'void (*)(struct i2c_atr *, u32,  const struct i2c_client *)' {aka 'void (*)(struct i2c_atr *, unsigned int,  const struct i2c_client *)'} from incompatible pointer type 'void (*)(struct i2c_atr *, u32,  u16)' {aka 'void (*)(struct i2c_atr *, unsigned int,  short unsigned int)'} [-Werror=incompatible-pointer-types]
     219 |         .detach_addr = max_ser_i2c_atr_detach_addr,
         |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/maxim-serdes/max_ser.c:219:24: note: (near initialization for 'max_ser_i2c_atr_ops.detach_client')
   drivers/media/i2c/maxim-serdes/max_ser.c: In function 'max_ser_i2c_atr_init':
>> drivers/media/i2c/maxim-serdes/max_ser.c:232:16: error: variable 'desc' has initializer but incomplete type
     232 |         struct i2c_atr_adap_desc desc = {
         |                ^~~~~~~~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:233:18: error: 'struct i2c_atr_adap_desc' has no member named 'chan_id'
     233 |                 .chan_id = 0,
         |                  ^~~~~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:233:28: warning: excess elements in struct initializer
     233 |                 .chan_id = 0,
         |                            ^
   drivers/media/i2c/maxim-serdes/max_ser.c:233:28: note: (near initialization for 'desc')
>> drivers/media/i2c/maxim-serdes/max_ser.c:232:34: error: storage size of 'desc' isn't known
     232 |         struct i2c_atr_adap_desc desc = {
         |                                  ^~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:240:21: error: too many arguments to function 'i2c_atr_new'
     240 |         priv->atr = i2c_atr_new(priv->client->adapter, priv->dev,
         |                     ^~~~~~~~~~~
   In file included from drivers/media/i2c/maxim-serdes/max_ser.c:9:
   include/linux/i2c-atr.h:53:17: note: declared here
      53 | struct i2c_atr *i2c_atr_new(struct i2c_adapter *parent, struct device *dev,
         |                 ^~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:247:16: error: too few arguments to function 'i2c_atr_add_adapter'
     247 |         return i2c_atr_add_adapter(priv->atr, &desc);
         |                ^~~~~~~~~~~~~~~~~~~
   include/linux/i2c-atr.h:88:5: note: declared here
      88 | int i2c_atr_add_adapter(struct i2c_atr *atr, u32 chan_id,
         |     ^~~~~~~~~~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_ser.c:232:34: warning: unused variable 'desc' [-Wunused-variable]
     232 |         struct i2c_atr_adap_desc desc = {
         |                                  ^~~~
   drivers/media/i2c/maxim-serdes/max_ser.c: In function 'max_ser_change_address':
>> drivers/media/i2c/maxim-serdes/max_ser.c:1577:16: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
    1577 |         val |= FIELD_PREP(MAX_SER_REG0_DEV_ADDR, new_addr);
         |                ^~~~~~~~~~
   drivers/media/i2c/maxim-serdes/max_ser.c: In function 'max_ser_i2c_atr_init':
>> drivers/media/i2c/maxim-serdes/max_ser.c:248:1: warning: control reaches end of non-void function [-Wreturn-type]
     248 | }
         | ^
   cc1: some warnings being treated as errors
--
>> drivers/media/i2c/maxim-serdes/max_des.c:991:10: error: 'const struct i2c_atr_ops' has no member named 'attach_addr'
     991 |         .attach_addr = max_des_ser_atr_attach_addr,
         |          ^~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:991:24: error: initialization of 'int (*)(struct i2c_atr *, u32,  const struct i2c_client *, u16)' {aka 'int (*)(struct i2c_atr *, unsigned int,  const struct i2c_client *, short unsigned int)'} from incompatible pointer type 'int (*)(struct i2c_atr *, u32,  u16,  u16)' {aka 'int (*)(struct i2c_atr *, unsigned int,  short unsigned int,  short unsigned int)'} [-Werror=incompatible-pointer-types]
     991 |         .attach_addr = max_des_ser_atr_attach_addr,
         |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/maxim-serdes/max_des.c:991:24: note: (near initialization for 'max_des_i2c_atr_ops.attach_client')
>> drivers/media/i2c/maxim-serdes/max_des.c:992:10: error: 'const struct i2c_atr_ops' has no member named 'detach_addr'
     992 |         .detach_addr = max_des_ser_atr_detach_addr,
         |          ^~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:992:24: error: initialization of 'void (*)(struct i2c_atr *, u32,  const struct i2c_client *)' {aka 'void (*)(struct i2c_atr *, unsigned int,  const struct i2c_client *)'} from incompatible pointer type 'void (*)(struct i2c_atr *, u32,  u16)' {aka 'void (*)(struct i2c_atr *, unsigned int,  short unsigned int)'} [-Werror=incompatible-pointer-types]
     992 |         .detach_addr = max_des_ser_atr_detach_addr,
         |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/maxim-serdes/max_des.c:992:24: note: (near initialization for 'max_des_i2c_atr_ops.detach_client')
   drivers/media/i2c/maxim-serdes/max_des.c: In function 'max_des_i2c_atr_init':
>> drivers/media/i2c/maxim-serdes/max_des.c:1023:33: error: 'I2C_ATR_F_STATIC' undeclared (first use in this function)
    1023 |                                 I2C_ATR_F_STATIC | I2C_ATR_F_PASSTHROUGH);
         |                                 ^~~~~~~~~~~~~~~~
   drivers/media/i2c/maxim-serdes/max_des.c:1023:33: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/media/i2c/maxim-serdes/max_des.c:1023:52: error: 'I2C_ATR_F_PASSTHROUGH' undeclared (first use in this function)
    1023 |                                 I2C_ATR_F_STATIC | I2C_ATR_F_PASSTHROUGH);
         |                                                    ^~~~~~~~~~~~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:1021:21: error: too many arguments to function 'i2c_atr_new'
    1021 |         priv->atr = i2c_atr_new(priv->client->adapter, priv->dev,
         |                     ^~~~~~~~~~~
   In file included from drivers/media/i2c/maxim-serdes/max_des.c:9:
   include/linux/i2c-atr.h:53:17: note: declared here
      53 | struct i2c_atr *i2c_atr_new(struct i2c_adapter *parent, struct device *dev,
         |                 ^~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:1031:24: error: variable 'desc' has initializer but incomplete type
    1031 |                 struct i2c_atr_adap_desc desc = {
         |                        ^~~~~~~~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:1032:26: error: 'struct i2c_atr_adap_desc' has no member named 'chan_id'
    1032 |                         .chan_id = i,
         |                          ^~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:1032:36: warning: excess elements in struct initializer
    1032 |                         .chan_id = i,
         |                                    ^
   drivers/media/i2c/maxim-serdes/max_des.c:1032:36: note: (near initialization for 'desc')
>> drivers/media/i2c/maxim-serdes/max_des.c:1031:42: error: storage size of 'desc' isn't known
    1031 |                 struct i2c_atr_adap_desc desc = {
         |                                          ^~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:1038:23: error: too few arguments to function 'i2c_atr_add_adapter'
    1038 |                 ret = i2c_atr_add_adapter(priv->atr, &desc);
         |                       ^~~~~~~~~~~~~~~~~~~
   include/linux/i2c-atr.h:88:5: note: declared here
      88 | int i2c_atr_add_adapter(struct i2c_atr *atr, u32 chan_id,
         |     ^~~~~~~~~~~~~~~~~~~
>> drivers/media/i2c/maxim-serdes/max_des.c:1031:42: warning: unused variable 'desc' [-Wunused-variable]
    1031 |                 struct i2c_atr_adap_desc desc = {
         |                                          ^~~~
   drivers/media/i2c/maxim-serdes/max_des.c: In function 'max_des_get_mbus_config':
>> drivers/media/i2c/maxim-serdes/max_des.c:1367:12: error: 'struct v4l2_mbus_config' has no member named 'link_freq'
    1367 |         cfg->link_freq = phy->link_frequency;
         |            ^~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP +663 drivers/media/i2c/maxim-serdes/max96717.c

   649	
   650	static int max96717_mux_set_rclkout(struct max96717_priv *priv, unsigned int group)
   651	{
   652		int ret;
   653	
   654		/* Enable PCLK output. */
   655		ret = regmap_set_bits(priv->regmap, MAX96717_REF_VTG1,
   656				      MAX96717_REF_VTG1_PCLKEN);
   657		if (ret)
   658			return ret;
   659	
   660		/* Set PCLK output to the RCLK pin. */
   661		ret = regmap_update_bits(priv->regmap, MAX96717_REF_VTG1,
   662					 MAX96717_REF_VTG1_PCLK_GPIO,
 > 663					 FIELD_PREP(MAX96717_REF_VTG1_PCLK_GPIO, group));
   664		if (ret)
   665			return ret;
   666	
   667		/* Enable RCLK output on PCLK. */
   668		ret = regmap_set_bits(priv->regmap, MAX96717_REF_VTG1,
   669				      MAX96717_REF_VTG1_RCLKEN_Y);
   670		if (ret)
   671			return ret;
   672	
   673		return 0;
   674	}
   675	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki