All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>,
	Netfilter Development <netfilter-devel@vger.kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH libnetfilter_log] autoconf: don't curl build script
Date: Mon, 10 Mar 2025 09:34:46 +0100	[thread overview]
Message-ID: <20250310083446.GA8451@breakpoint.cc> (raw)
In-Reply-To: <Z85FG/1qImu3tiSS@slk15.local.net>

Duncan Roe <duncan_roe@optusnet.com.au> wrote:
> | This is a bad idea; cloning repo followed by "./autogen.sh" brings
> | repository into a changed state.
> 
> Agree with the above, except IMHO the "bad idea" is to have a frozen version of
> build_man.sh in the repository at all.

I absolutely hate the idea of fetching stuff at build time.
And in this case, we fetch an exectuable shell script from
untrusted location.

It has backdoor written all over it.

  reply	other threads:[~2025-03-10  8:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09 10:55 [PATCH libnetfilter_log] autoconf: don't curl build script Florian Westphal
2025-03-10  1:49 ` Duncan Roe
2025-03-10  8:34   ` Florian Westphal [this message]
2025-03-10 10:13     ` Duncan Roe
2025-03-10 20:19 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250310083446.GA8451@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.