From: Stephen Hemminger <stephen@networkplumber.org>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute] libgenl: report a verbose error if rtnl_talk fails
Date: Mon, 10 Mar 2025 09:12:12 -0700 [thread overview]
Message-ID: <20250310091212.7dba57d2@hermes.local> (raw)
In-Reply-To: <20250228133431.20296-1-kirjanov@gmail.com>
On Fri, 28 Feb 2025 16:34:31 +0300
Denis Kirjanov <kirjanov@gmail.com> wrote:
> Currenlty rtnl_talk() doesn't give us the reason
> if it fails.
>
> Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
> ---
Don't think this is needed.
- inside rtnl_talk, it already prints (using perror) if it is a kernel reported error
- lots of other places call rtnl_talk() what is special about genl
Better to move any required error prints into libnetlink.c
Even better is to make sure any errors in kernel are using extack to give
better messages.
prev parent reply other threads:[~2025-03-10 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 13:34 [PATCH iproute] libgenl: report a verbose error if rtnl_talk fails Denis Kirjanov
2025-03-10 16:12 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310091212.7dba57d2@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.