From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF59170A11; Mon, 10 Mar 2025 02:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741573489; cv=none; b=bQ4RpGPCd/VaPRs5AnjSSv4yYJ2EqpYQid+OKLft4ogGHYjB9NFyGS2vAcMwlieYGsVpzYxDROUwuM28kCUsK2BPauV1goNW7I7+e/Ti0XyC7vbPynRE3Qt71aP6WvlXYD1Hu6jyNZ0HxqVRpXRrbJppgOdMARnIZTZqlQRIRkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741573489; c=relaxed/simple; bh=AIBUsJ/+UQ0z6zW9MVzwQe6CPRtiPuYH7kM/aGJmeAg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=azZDzz+RYWNvMAZx03VbVXH7VXQ13hlxZGPbH+yz7GrbIV2BJmZs48wilBtYZ7PUQc3xFJDxFTtxEckAwn1Vjo0t8AgX9sWquwb82hEjTjikMMBmyFniLczYob/ZxnK9iYMHzCZhAkxSOOYTy6gMAyNAIUGzDCWoSanQ+SotlTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tv0H9t4Z; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tv0H9t4Z" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2ff6a98c638so6972091a91.0; Sun, 09 Mar 2025 19:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741573487; x=1742178287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8UgdkfR5ZJpIqw3CxaKBXneuVyU1q32SHQHrzDgtsJo=; b=Tv0H9t4Z3tXZ09oTXqSxuhDREdnjojZ2dTqBVRzFuDGERFM6ivJFEhYRlIR9z8wEbL Bow1TEME1s45cyhgtzh8eChDsUVnFOaxzV8Qazk5XG2iBV3ueBfOK8pGV9OrNc3lv7WK uIrx1r0PLBXXdkdOQmneBVSXY/lHI1Cjs+pRX3+XbJIyKBcfnyWbLQ6OPhALdLiDvte0 EJCNYa3IU9w41AQrCSuirxNydn6c5tiwzT6I2WoRu3QRxG0OsX+gwzROYtX0XuRu/fCu zWHHkc5OhkeFQulCAOX+PVB5ceKPEzPRhQ94ffe86Gde6FwuM6ADrunrC4RpvBAWgGXS JG+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741573487; x=1742178287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UgdkfR5ZJpIqw3CxaKBXneuVyU1q32SHQHrzDgtsJo=; b=J+0BHeGf0S5zQNurGeP069xk4ZhwR5ZHKA4FZMVF/J8nNVkCLAJi6e8nLoqpxPlKQe YW/p7zvaPUTfYg+1ivsek1fQj9H7eQemqg/XaOSv7Na+0kVPzhYfYxk/M0Dq21cpBS4u 83TkVKMIssJXZ7joJvBI27ERJhoVsZD6wj6YTrHhTvfLlkkBiBPEtQkU0+I0IKjdSTr8 mDfdj3mWYktQ47k2crQPcp+67JE+7iK2c8jobYK41cK8m4jgeHTeNvDS/MMxokR4Fbex oBGDTjHPA0VpHOYUEOVR60cAl35CGmJTeCCNT9tDI3iA7b7NMHklTqI6gEnNsqdaAeAw 688g== X-Forwarded-Encrypted: i=1; AJvYcCUQqiTSNaf3MBHeT0ZQX09nFUFgcxH+CwhgotSe9mf8e3+sZn5+O6nrih83mZdsdvrCrCw=@vger.kernel.org, AJvYcCXhkqiCYtPC73bB6382f49J18SZgQEiN/yCvSYhiX3iA4BzF8eiX62S8KNixLxsUs0xmbAKSO64Gofgbge3@vger.kernel.org, AJvYcCXxm6U/05mWl1Q4q/c1P1E/GRZFBFdbIuGjBBMXW3IkhPINPfh/jiXTw+mfeu987ULLlmFV9ENu@vger.kernel.org X-Gm-Message-State: AOJu0Yx8yRnCldkU0mgTSp8D9TXo8rEdpQt986Uszmu6IGg4DTyk/55J S2exBb0AuE2nVFYN5Ro3u02Ui1B+ka+wn8xF+D8NDzG0ltna+I2z X-Gm-Gg: ASbGncsP7RQnKjYibuUE8JRPdbcVQDOc05TXYgh9zpeufKgwBomIvY5MypPVgd49q4i wDN0ekP+8/ePQn0kuVZKMGcp0SO07jOPg/57zhsbVR4xfXgNloh8D6VItVFtp42xlPDpode6+vt RBiu5k5pOhLdnZcJju7AiAENAbX+ARN+rz1l2Pi0e/G7KFVZ4xPt0QeN/dJDeGDHdafDhWrEPF+ +M35sJChKmbe5LO/IWu5a7PDgoHPJblS7/dtjLHEb0Hfsi05nJYkcX5bFI+wMaTX2pzG94JOykg tlcQwjRaZSqiMlkI8YSWPvdf7BQjtU0/0J0MZA== X-Google-Smtp-Source: AGHT+IEu8uuETGfMoaM3EPE2WfaTTndfm3F2AV9+L8B8fVo7WT9YAUCmxKGewCLzkt/NfrR5yWSoUw== X-Received: by 2002:a17:90b:4cca:b0:2ff:72f8:3708 with SMTP id 98e67ed59e1d1-2ff7ce837c9mr21980902a91.17.1741573486614; Sun, 09 Mar 2025 19:24:46 -0700 (PDT) Received: from localhost ([144.24.43.60]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e7ffdd3sm8645058a91.39.2025.03.09.19.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Mar 2025 19:24:46 -0700 (PDT) Date: Mon, 10 Mar 2025 10:24:32 +0800 From: Furong Xu <0x1207@gmail.com> To: Faizal Rahim Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Russell King , Vladimir Oltean , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Choong Yong Liang , Chwee-Lin Choong , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH iwl-next v9 03/14] net: ethtool: mm: reset verification status when link is down Message-ID: <20250310102432.000032ad@gmail.com> In-Reply-To: <20250309104648.3895551-4-faizal.abdul.rahim@linux.intel.com> References: <20250309104648.3895551-1-faizal.abdul.rahim@linux.intel.com> <20250309104648.3895551-4-faizal.abdul.rahim@linux.intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 9 Mar 2025 06:46:37 -0400 Faizal Rahim wrote: > When the link partner goes down, "ethtool --show-mm" still displays > "Verification status: SUCCEEDED," reflecting a previous state that is > no longer valid. > > Reset the verification status to ensure it reflects the current state. > > Signed-off-by: Faizal Rahim > --- > net/ethtool/mm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c > index bfd988464d7d..ad9b40034003 100644 > --- a/net/ethtool/mm.c > +++ b/net/ethtool/mm.c > @@ -415,6 +415,10 @@ void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up) > /* New link => maybe new partner => new verification process */ > ethtool_mmsv_apply(mmsv); > } else { > + /* Reset the reported verification state while the link is down */ > + if (mmsv->verify_enabled) > + mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; > + > /* No link or pMAC not enabled */ > ethtool_mmsv_configure_pmac(mmsv, false); > ethtool_mmsv_configure_tx(mmsv, false); Reviewed-by: Furong Xu <0x1207@gmail.com> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA97C28B28 for ; Mon, 10 Mar 2025 02:24:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F34AC606F7; Mon, 10 Mar 2025 02:24:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7twbb5EKRRbp; Mon, 10 Mar 2025 02:24:54 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4003960773 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1741573494; bh=8UgdkfR5ZJpIqw3CxaKBXneuVyU1q32SHQHrzDgtsJo=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N2bEoluvb5LglV1p5WqI6NBzPce4PWNcFxjgJXaupLfuWF6V3mWJwpGT0IYIX0lc+ FPMLEZ4Tgvy3+IdWNrjO173r7986uw737hjgJn2xuBCr5OZ48kUQYQsxPfsdBILyth b+ta4ccEotx5CI3Ioe5RNhmf9L6Di7GHbr1pDUH/ouQxVSETb5Fa6sPHyWsaz1HNFq ps84vDiFl8XEJ4zQ0ANwLLBRkX/1Y4gdu4RCNGDsygjwgenVIzTzX14vTX0gl3dKfm Q/tnNNIB26UIdXwXHwgmMJh/luccBSv1Pn4bfcu13jrg5+I6c4pcCJnPybmng7IVbI htO6c+IEELWsw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 4003960773; Mon, 10 Mar 2025 02:24:54 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 330341E3 for ; Mon, 10 Mar 2025 02:24:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 16331400D3 for ; Mon, 10 Mar 2025 02:24:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id N8lVH6WOOoog for ; Mon, 10 Mar 2025 02:24:47 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1029; helo=mail-pj1-x1029.google.com; envelope-from=0x1207@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 75BAE400BA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 75BAE400BA Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by smtp2.osuosl.org (Postfix) with ESMTPS id 75BAE400BA for ; Mon, 10 Mar 2025 02:24:47 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2ff6a98c638so6972090a91.0 for ; Sun, 09 Mar 2025 19:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741573487; x=1742178287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UgdkfR5ZJpIqw3CxaKBXneuVyU1q32SHQHrzDgtsJo=; b=B+TFil3y/QiLTnjsfwmnEprrs6a+J/dc6OUijo6wvM8imtjcZQ1FZGhVLyk3G/6Q0i VLp22FAhzXRS494M/qun6kg5UBn4y2+7J6PriS9y1JoKz/hBjn4AdQyqZD0P4unsPZ5d 1yjT7OkSkqs+4MnPiErrPher683aWkUJPLNyqmMGqgb0lH+vt+wTiP8YG29JX3O6UuOS t8ilvIK90R+wDpp++yZKkCgvIZpSJ7VpqS5MH13hHMmNPHGwBcIy15u8TeRVIlzA2cSP 8c98e/PMXelgZwvBDl85d5TqmusAOCVxHJNetjt+qE0FNIcnpVU2OuAuvKwzjEifjM4y rP1Q== X-Forwarded-Encrypted: i=1; AJvYcCVw/pAed/xiwNokpYPkpG0xIK3rjr8j4EDI3MWUmnNvHwwHoOm9LD1mlOlIBcG0jLRL15jTCGugla1lceLbmws=@lists.osuosl.org X-Gm-Message-State: AOJu0YxQ42Ttv59J3MVEAZwNzmrFXNdY1UKWdWuQasEzq3eziPXB1xBC WVtvdq90r+3jRcJ9VXIG6ennoWUW/86h5MAJGBHlQHDbdH6DdQ0p X-Gm-Gg: ASbGnctNfLNCWuEl91uNNuCKvIMF5RFbsHH8Ks7KfGHbEVXLC+aFt7J3wqezpulNA2L oi2y+k0K91UoGOlKfd4qxD1NzxZj8RlSd3r/G3fBrIrMFcEXWz2hqNx/3teijT38+dBh7y2kqxx JxiV8k10gGLnyBtU9H5c7lkAIJI3KetfMYOPCDKF8yFjD7HEgTwxeZUe5DIjTvN/ALT27taL2VS WC0HfzUabJdxZBYcd0Ce8rQqAKeRHwtyqA2UYxrvQOBwgROgYBOYf0G1dNXGusJnt4EF+wtiLWr SqjzLYiazw90L54KNT8ms5uivzIhU9MNJbKGpA== X-Google-Smtp-Source: AGHT+IEu8uuETGfMoaM3EPE2WfaTTndfm3F2AV9+L8B8fVo7WT9YAUCmxKGewCLzkt/NfrR5yWSoUw== X-Received: by 2002:a17:90b:4cca:b0:2ff:72f8:3708 with SMTP id 98e67ed59e1d1-2ff7ce837c9mr21980902a91.17.1741573486614; Sun, 09 Mar 2025 19:24:46 -0700 (PDT) Received: from localhost ([144.24.43.60]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e7ffdd3sm8645058a91.39.2025.03.09.19.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Mar 2025 19:24:46 -0700 (PDT) Date: Mon, 10 Mar 2025 10:24:32 +0800 From: Furong Xu <0x1207@gmail.com> To: Faizal Rahim Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Russell King , Vladimir Oltean , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Choong Yong Liang , Chwee-Lin Choong , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Message-ID: <20250310102432.000032ad@gmail.com> In-Reply-To: <20250309104648.3895551-4-faizal.abdul.rahim@linux.intel.com> References: <20250309104648.3895551-1-faizal.abdul.rahim@linux.intel.com> <20250309104648.3895551-4-faizal.abdul.rahim@linux.intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741573487; x=1742178287; darn=lists.osuosl.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8UgdkfR5ZJpIqw3CxaKBXneuVyU1q32SHQHrzDgtsJo=; b=N0U3u5/hln1GYrDlH0xFELQRDcggHbhGbXY3VyztXrjrauOK7otD/L7/xsVnis+MDZ VMJbrZAF/wBvlQCTdgwgM8hESGrILF2pBV3ksAodR7o3WI/VrDiB2A9qc4ToXJ0Bwtqg GxvEFKf5r48N04rRxzkVzf6QouyBgljMXAHKe7EEy4hs+G4WN1G2UF1bDfgLJIAd/mqO uGvES0cQcdeRoAG5HAY4iajqR8tdqoVXedkCAmpFGvCvUazjiQbUQrfjsO5C5x62Xacc am0VYq5ZgWkIz0cPpSQZny54sZKmp+KB8iF6vldfsVIAgE2eYFjdZ1wZRHpPIM3VFMAo cxGg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=N0U3u5/h Subject: Re: [Intel-wired-lan] [PATCH iwl-next v9 03/14] net: ethtool: mm: reset verification status when link is down X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sun, 9 Mar 2025 06:46:37 -0400 Faizal Rahim wrote: > When the link partner goes down, "ethtool --show-mm" still displays > "Verification status: SUCCEEDED," reflecting a previous state that is > no longer valid. > > Reset the verification status to ensure it reflects the current state. > > Signed-off-by: Faizal Rahim > --- > net/ethtool/mm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c > index bfd988464d7d..ad9b40034003 100644 > --- a/net/ethtool/mm.c > +++ b/net/ethtool/mm.c > @@ -415,6 +415,10 @@ void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up) > /* New link => maybe new partner => new verification process */ > ethtool_mmsv_apply(mmsv); > } else { > + /* Reset the reported verification state while the link is down */ > + if (mmsv->verify_enabled) > + mmsv->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; > + > /* No link or pMAC not enabled */ > ethtool_mmsv_configure_pmac(mmsv, false); > ethtool_mmsv_configure_tx(mmsv, false); Reviewed-by: Furong Xu <0x1207@gmail.com>