From: Stephen Hemminger <stephen@networkplumber.org>
To: Matteo Croce <technoboy85@gmail.com>
Cc: netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>,
Matteo Croce <teknoraver@meta.com>
Subject: Re: [PATCH iproute2-next v2] color: default to dark color theme
Date: Mon, 10 Mar 2025 14:12:16 -0700 [thread overview]
Message-ID: <20250310141216.5cdfd133@hermes.local> (raw)
In-Reply-To: <20250310203609.4341-1-technoboy85@gmail.com>
On Mon, 10 Mar 2025 21:36:09 +0100
Matteo Croce <technoboy85@gmail.com> wrote:
> From: Matteo Croce <teknoraver@meta.com>
>
> The majority of Linux terminals are using a dark background.
> iproute2 tries to detect the color theme via the `COLORFGBG` environment
> variable, and defaults to light background if not set.
>
This is not true. The default gnome terminal color palette is not dark.
> Change the default behaviour to dark background, and while at it change
> the current logic which assumes that the color code is a single digit.
>
> Signed-off-by: Matteo Croce <teknoraver@meta.com>
The code was added to follow the conventions of other Linux packages.
Probably best to do something smarter (like util-linux) or more exactly
follow what systemd or vim are doing.
next prev parent reply other threads:[~2025-03-10 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 20:36 [PATCH iproute2-next v2] color: default to dark color theme Matteo Croce
2025-03-10 21:12 ` Stephen Hemminger [this message]
2025-03-13 11:28 ` Phil Sutter
2025-03-13 11:41 ` Matteo Croce
2025-03-13 12:05 ` Phil Sutter
2025-03-13 16:30 ` Stephen Hemminger
2025-03-14 17:12 ` Phil Sutter
2025-03-14 17:37 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310141216.5cdfd133@hermes.local \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=technoboy85@gmail.com \
--cc=teknoraver@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.