From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com,
jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com,
matthew.brost@intel.com, jianxun.zhang@intel.com,
shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org
Subject: [PATCH v7 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults
Date: Mon, 10 Mar 2025 17:18:33 +0000 [thread overview]
Message-ID: <20250310171834.78299-6-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20250310171834.78299-1-jonathan.cavitt@intel.com>
Add a new field to the xe_pagefault struct, address_type, that tracks
the type of fault the pagefault incurred.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++
drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c
index 7661b9ad1cd0..69ac8f437d11 100644
--- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
+++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
@@ -206,11 +206,13 @@ static int handle_pagefault(struct xe_gt *gt, struct xe_pagefault *pf)
vma = lookup_vma(vm, pf->page_addr);
if (!vma) {
+ pf->address_type = DRM_XE_FAULT_ADDRESS_TYPE_NONE_EXT;
err = -EINVAL;
goto unlock_vm;
}
if (xe_vma_read_only(vma) && pf->access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) {
+ pf->address_type = DRM_XE_FAULT_ADDRESS_TYPE_WRITE_INVALID_EXT;
err = -EPERM;
goto unlock_vm;
}
@@ -284,6 +286,7 @@ static bool get_pagefault(struct pf_queue *pf_queue, struct xe_pagefault *pf)
pf->asid = FIELD_GET(PFD_ASID, desc->dw1);
pf->vfid = FIELD_GET(PFD_VFID, desc->dw2);
pf->access_type = FIELD_GET(PFD_ACCESS_TYPE, desc->dw2);
+ pf->address_type = 0;
pf->fault_type = FIELD_GET(PFD_FAULT_TYPE, desc->dw2);
pf->page_addr = (u64)(FIELD_GET(PFD_VIRTUAL_ADDR_HI, desc->dw3)) <<
PFD_VIRTUAL_ADDR_HI_SHIFT;
diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.h b/drivers/gpu/drm/xe/xe_gt_pagefault.h
index 33616043d17a..969f7b458d3f 100644
--- a/drivers/gpu/drm/xe/xe_gt_pagefault.h
+++ b/drivers/gpu/drm/xe/xe_gt_pagefault.h
@@ -17,6 +17,7 @@ struct xe_pagefault {
u16 pdata;
u8 vfid;
u8 access_type;
+ u8 address_type;
u8 fault_type;
u8 fault_level;
u8 engine_class;
--
2.43.0
next prev parent reply other threads:[~2025-03-10 17:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 17:18 [PATCH v7 0/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl Jonathan Cavitt
2025-03-10 17:18 ` [PATCH v7 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2025-03-10 17:18 ` [PATCH v7 2/6] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header Jonathan Cavitt
2025-03-10 18:20 ` Michal Wajdeczko
2025-03-10 21:30 ` Cavitt, Jonathan
2025-03-11 8:26 ` Michal Wajdeczko
2025-03-10 17:18 ` [PATCH v7 3/6] drm/xe/xe_vm: Add per VM pagefault info Jonathan Cavitt
2025-03-10 18:36 ` Michal Wajdeczko
2025-03-10 17:18 ` [PATCH v7 4/6] drm/xe/uapi: Define drm_xe_vm_get_faults Jonathan Cavitt
2025-03-11 3:17 ` Zhang, Jianxun
2025-03-11 4:50 ` Matthew Brost
2025-03-11 14:11 ` Cavitt, Jonathan
2025-03-12 16:28 ` Zhang, Jianxun
2025-03-12 16:46 ` Cavitt, Jonathan
2025-03-12 4:18 ` Zhang, Jianxun
2025-03-10 17:18 ` Jonathan Cavitt [this message]
2025-03-10 17:18 ` [PATCH v7 6/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl Jonathan Cavitt
2025-03-10 17:45 ` ✓ CI.Patch_applied: success for drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl (rev2) Patchwork
2025-03-10 17:45 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-10 17:46 ` ✓ CI.KUnit: success " Patchwork
2025-03-10 18:03 ` ✓ CI.Build: " Patchwork
2025-03-10 18:05 ` ✓ CI.Hooks: " Patchwork
2025-03-10 18:06 ` ✓ CI.checksparse: " Patchwork
2025-03-10 18:28 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-11 12:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-11 13:57 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310171834.78299-6-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jianxun.zhang@intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=saurabhg.gupta@intel.com \
--cc=shuicheng.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.