From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9114C282DE for ; Mon, 10 Mar 2025 21:14:19 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web10.50191.1741641251851689033 for ; Mon, 10 Mar 2025 14:14:13 -0700 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 2556440CAF; Mon, 10 Mar 2025 21:14:11 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M17W81Qju54N; Mon, 10 Mar 2025 21:14:11 +0000 (UTC) Received: from mail.denix.org (pool-100-15-87-159.washdc.fios.verizon.net [100.15.87.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id E471A40C1C; Mon, 10 Mar 2025 21:14:07 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 500541642DE; Mon, 10 Mar 2025 17:14:07 -0400 (EDT) Date: Mon, 10 Mar 2025 17:14:07 -0400 From: Denys Dmytriyenko To: b-brnich@ti.com Cc: meta-ti@lists.yoctoproject.org, Ryan Eatmon , Darren Etheridge Subject: Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module Message-ID: <20250310211407.GT1879@denix.org> References: <20250306203749.794759-1-b-brnich@ti.com> <182A59C7642211D5.31492@lists.yoctoproject.org> <182B88F400236EE2.13955@lists.yoctoproject.org> <20250310202926.GS1879@denix.org> <20250310203953.odjau32sbqbulruq@udba0500997> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310203953.odjau32sbqbulruq@udba0500997> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 10 Mar 2025 21:14:19 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-ti/message/18367 On Mon, Mar 10, 2025 at 03:39:53PM -0500, Brandon Brnich via lists.yoctoproject.org wrote: > Hi Denys, > > On 16:29-20250310, Denys Dmytriyenko wrote: > > On Mon, Mar 10, 2025 at 03:50:56PM -0400, Denys Dmytriyenko wrote: > > > On Thu, Mar 06, 2025 at 06:15:13PM -0500, Denys Dmytriyenko wrote: > > > > On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote: > > > > > During 10.0 LTS bringup, the decision was made that it would be the last LTS > > > > > that carried the IMG VXE and VXD driver in tree. Driver is now hosted on > > > > > git.ti.com. This recipe is responsible for pulling in the driver, > > > > > building it, and packaging it within the J721e SDK. > > > > > > > > > > Signed-off-by: Brandon Brnich > > > > > --- > > > > > > > > > > This build was tested by changing the kernel to point towards latest > > > > > head that has relevant device tree changes and config options. Build is > > > > > successful with those changes and no warnings are present. > > > > > > > > > > .../ti-vxe-vxd-driver_6.12.bb | 23 +++++++++++++++++++ > > > > > 1 file changed, 23 insertions(+) > > > > > create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb > > > > > > > > > > diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb > > > > > new file mode 100644 > > > > > index 00000000..fa2d3792 > > > > > --- /dev/null > > > > > +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb > > > > > @@ -0,0 +1,23 @@ > > > > > +DESCRIPTION = "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC" > > > > > > > > Shorter SUMMARY is missing? > > Should I just change DESCRIPTION to SUMMARY? Why need both? Sigh, I'm becoming a "broken record"... https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-SUMMARY SUMMARY - A short summary for the recipe, which is 72 characters or less. This is mandatory. https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-DESCRIPTION DESCRIPTION - A long description for the recipe. This is optional - SUMMARY is used if omitted. > > > > > +LICENSE = "GPL-2.0-only" > > > > > +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b" > > > > > + > > > > > +inherit module > > > > > + > > > > > +PACKAGE_ARCH = "${MACHINE_ARCH}" > > > > > + > > > > > +COMPATIBLE_MACHINE = "j721e" > > > > > + > > > > > +DEPENDS += "virtual/kernel" > > > > > + > > > > > +BRANCH = "scarthgap/k${PV}" > > > > > + > > > > > +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}" > > > > > > Also, SRC_URI is incorrect - should be git://git.ti.com/git/multimedia/... for > > > https access (i.e. one level of /git/ is missing): > > > > > > WARNING: ti-vxe-vxd-driver-6.12-r0 do_fetch: Failed to fetch URL git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=scarthgap/k6.12, attempting MIRRORS if available > > > > > > Just do this to see other examples in meta-ti: > > > > > > $ grep 'git://git.ti.com' * -r > > Okay will also fix. > > > > > And it fails to build: > > > > | /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:24:9: warning: "MAX" redefined > > | 24 | #define MAX(a, b, type) ({ \ > > | | ^~~ > > | In file included from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/kernel.h:28, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/cpufeature.h:26, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/processor.h:38, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/sched.h:13, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/ratelimit.h:6, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dev_printk.h:16, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/device.h:15, > > | from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dma-mapping.h:8, > > | from /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:16: > > | /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/minmax.h:330:9: note: this is the location of the previous definition > > | 330 | #define MAX(a,b) __cmp(max,a,b) > > | | ^~~ > > | LD [M] /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.o > > | LD [M] /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.o > > | MODPOST /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers > > | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.ko] undefined! > > | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.ko] undefined! > > | make[4]: *** [/OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/scripts/Makefile.modpost:145: /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers] Error 1 > > > > I added this in the notes section that the kernel commit needed to point > at the HEAD of TI's 6.12.y-cicd branch in order to build due to a config > issue. The driver built and was validated against Scarthgap. This has been merged to master-wip, which is what I'm testing now. It seems required dependencies are not met. > This patch can already be found in scarthgap tree[0]. I will submit new > patch to fix up the other comments you have made. > > [0]: https://git.ti.com/cgit/arago-project/meta-ti/commit/?h=scarthgap&id=296344c8ea44b958269352cd5a417adfd9df9857 This is unacceptable!! The first comment was made the same day within couple of hours of the patch being posted to the list: https://patchwork.yoctoproject.org/project/ti/patch/20250306203749.794759-1-b-brnich@ti.com/ There should be AT LEAST 24-48 hours allowed for patch reviews and comments. There should NOT be any pressure applied on the maintainer to merge the patches immediately.