From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Alex Shi <alexs@kernel.org>, Yanteng Si <si.yanteng@linux.dev>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Liu Ying <victor.liu@nxp.com>,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: [PATCH v2 0/2] vsprintf: remove redundant %pCn format specifier
Date: Tue, 11 Mar 2025 10:21:21 +0100 [thread overview]
Message-ID: <20250311-vsprintf-pcn-v2-0-0af40fc7dee4@bootlin.com> (raw)
There are two printk format specifiers for clocks: %pC and %pCn, and they
print exactly the same string. Geert confirmed the intended reason for
having two was that %pC would act as a default, like some (but not all)
formats do. However there seem to be no advantage in having two instead of
one, especially now that there is no other %pC specifier since commit
666902e42fd8 ("lib/vsprintf: Remove atomic-unsafe support for %pCr").
Definitely having two without properly documenting they do the same creates
misunderstandings [0].
Since %pCn is used in a single place, replace it with %pC and remove %pCn
to simplify such format specifiers implementation and avoid
misunderstandings.
[0] https://lore.kernel.org/dri-devel/f8df2b5e-b005-4ada-8108-159b2b94a72e@nxp.com/
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Changes in v2:
- Add Chinese translation
- Link to v1: https://lore.kernel.org/r/20250307-vsprintf-pcn-v1-0-df0b2ccf610f@bootlin.com
---
Luca Ceresoli (2):
thermal: bcm2835: use %pC instead of %pCn
vsprintf: remove redundant and unused %pCn format specifier
Documentation/core-api/printk-formats.rst | 3 +--
Documentation/translations/zh_CN/core-api/printk-formats.rst | 3 +--
drivers/thermal/broadcom/bcm2835_thermal.c | 2 +-
lib/vsprintf.c | 10 ++--------
4 files changed, 5 insertions(+), 13 deletions(-)
---
base-commit: 4d872d51bc9d7b899c1f61534e3dbde72613f627
change-id: 20250307-vsprintf-pcn-8a43e3b0d43e
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
next reply other threads:[~2025-03-11 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 9:21 Luca Ceresoli [this message]
2025-03-11 9:21 ` [PATCH v2 1/2] thermal: bcm2835: use %pC instead of %pCn Luca Ceresoli
2025-03-11 9:21 ` [PATCH v2 2/2] vsprintf: remove redundant and unused %pCn format specifier Luca Ceresoli
2025-03-11 9:34 ` Yanteng Si
2025-03-11 14:36 ` Petr Mladek
2025-04-07 16:46 ` Luca Ceresoli
2025-04-08 7:33 ` Petr Mladek
2025-04-18 10:08 ` Daniel Lezcano
2025-04-18 10:10 ` [PATCH v2 0/2] vsprintf: remove redundant " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311-vsprintf-pcn-v2-0-0af40fc7dee4@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukasz.luba@arm.com \
--cc=mturquette@baylibre.com \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=rjui@broadcom.com \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=senozhatsky@chromium.org \
--cc=si.yanteng@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
--cc=victor.liu@nxp.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.