From: kernel test robot <lkp@intel.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: oe-kbuild-all@lists.linux.dev,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: [watchdog-next:v6.15-rc1 4/7] drivers/watchdog/lenovo_se30_wdt.c:272:31: error: implicit declaration of function 'devm_ioremap'
Date: Tue, 11 Mar 2025 07:16:07 +0800 [thread overview]
Message-ID: <202503110752.bb6mPHFb-lkp@intel.com> (raw)
tree: git://www.linux-watchdog.org/linux-watchdog-next.git v6.15-rc1
head: d127d9ce2c8ee87d51fdcfff7895661a3c06fb24
commit: c284153a2c5537db4fec51ac850c17d2eb1ffcfe [4/7] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo SE30 platform
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250311/202503110752.bb6mPHFb-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250311/202503110752.bb6mPHFb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503110752.bb6mPHFb-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/watchdog/lenovo_se30_wdt.c: In function 'lenovo_se30_wdt_probe':
>> drivers/watchdog/lenovo_se30_wdt.c:272:31: error: implicit declaration of function 'devm_ioremap' [-Wimplicit-function-declaration]
272 | priv->shm_base_addr = devm_ioremap(dev, base_phys, SHM_WIN_SIZE);
| ^~~~~~~~~~~~
>> drivers/watchdog/lenovo_se30_wdt.c:272:29: error: assignment to 'unsigned char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
272 | priv->shm_base_addr = devm_ioremap(dev, base_phys, SHM_WIN_SIZE);
| ^
vim +/devm_ioremap +272 drivers/watchdog/lenovo_se30_wdt.c
233
234 static int lenovo_se30_wdt_probe(struct platform_device *pdev)
235 {
236 struct device *dev = &pdev->dev;
237 struct lenovo_se30_wdt *priv;
238 unsigned long base_phys;
239 unsigned short val;
240 int err;
241
242 err = superio_enter(UNLOCK_KEY, SIO_REG, LNV_SE30_NAME);
243 if (err)
244 return err;
245
246 val = superio_inb(SIO_REG, CHIPID_REG) << 8;
247 val |= superio_inb(SIO_REG, CHIPID_REG + 1);
248
249 if ((val & CHIPID_MASK) != LNV_SE30_ID) {
250 superio_exit(LOCK_KEY, SIO_REG);
251 return -ENODEV;
252 }
253
254 superio_outb(SIO_REG, LDN_REG, LD_NUM_SHM);
255 base_phys = (superio_inb(SIO_REG, LD_BASE_ADDR) |
256 (superio_inb(SIO_REG, LD_BASE_ADDR + 1) << 8) |
257 (superio_inb(SIO_REG, LD_BASE_ADDR + 2) << 16) |
258 (superio_inb(SIO_REG, LD_BASE_ADDR + 3) << 24)) &
259 0xFFFFFFFF;
260
261 superio_exit(LOCK_KEY, SIO_REG);
262 if (base_phys == 0xFFFFFFFF || base_phys == 0)
263 return -ENODEV;
264
265 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
266 if (!priv)
267 return -ENOMEM;
268
269 if (!devm_request_mem_region(dev, base_phys, SHM_WIN_SIZE, LNV_SE30_NAME))
270 return -EBUSY;
271
> 272 priv->shm_base_addr = devm_ioremap(dev, base_phys, SHM_WIN_SIZE);
273
274 priv->wdt_cfg.mod = WDT_MODULE;
275 priv->wdt_cfg.idx = WDT_CFG_INDEX;
276 priv->wdt_cnt.mod = WDT_MODULE;
277 priv->wdt_cnt.idx = WDT_CNT_INDEX;
278
279 priv->wdt.ops = &lenovo_se30_wdt_ops;
280 priv->wdt.info = &lenovo_se30_wdt_info;
281 priv->wdt.timeout = WATCHDOG_TIMEOUT; /* Set default timeout */
282 priv->wdt.min_timeout = MIN_TIMEOUT;
283 priv->wdt.max_timeout = MAX_TIMEOUT;
284 priv->wdt.parent = dev;
285
286 watchdog_init_timeout(&priv->wdt, timeout, dev);
287 watchdog_set_drvdata(&priv->wdt, priv);
288 watchdog_set_nowayout(&priv->wdt, nowayout);
289 watchdog_stop_on_reboot(&priv->wdt);
290 watchdog_stop_on_unregister(&priv->wdt);
291
292 return devm_watchdog_register_device(dev, &priv->wdt);
293 }
294
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-03-10 23:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503110752.bb6mPHFb-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux@roeck-us.net \
--cc=mpearson-lenovo@squebb.ca \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.