From: Christoph Hellwig <hch@lst.de>
To: Huan Yang <link@vivo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
Ryan Roberts <ryan.roberts@arm.com>, Zi Yan <ziy@nvidia.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com, Christoph Hellwig <hch@lst.de>,
Bingbu Cao <bingbu.cao@linux.intel.com>
Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns
Date: Wed, 12 Mar 2025 07:18:36 +0100 [thread overview]
Message-ID: <20250312061836.GA12841@lst.de> (raw)
In-Reply-To: <20250312061513.1126496-1-link@vivo.com>
On Wed, Mar 12, 2025 at 02:15:12PM +0800, Huan Yang wrote:
> When invoke vmap_pfns, it call vmap_pfn_apply to set pfn into pte.
> It check pfn is valid, if true then warn and return.
>
> This is a mischeck, actually we need set a valid pfn into pte, not an
> invalid pfn.
As just discussed this is wrong. vmap_pfn is for mapping non-page
PFNs and the check is what enforces that. What is the point of having
that detailed discussion if you just send the broken patch anyway with
a commit log not even acknowledging the facts?
next prev parent reply other threads:[~2025-03-12 6:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 6:15 [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns Huan Yang
2025-03-12 6:18 ` Christoph Hellwig [this message]
2025-03-17 2:12 ` Huan Yang
2025-03-17 5:29 ` Bingbu Cao
2025-03-17 5:53 ` Christoph Hellwig
2025-03-17 7:42 ` Huan Yang
2025-03-18 6:48 ` Christoph Hellwig
2025-03-18 8:20 ` Huan Yang
2025-03-18 8:33 ` Christoph Hellwig
2025-03-18 8:39 ` Huan Yang
2025-03-18 8:44 ` Christoph Hellwig
2025-03-18 8:50 ` Huan Yang
[not found] ` <20250319050359.3484-1-hdanton@sina.com>
2025-03-19 8:08 ` Christoph Hellwig
[not found] ` <20250319112651.3502-1-hdanton@sina.com>
2025-03-24 2:13 ` Huan Yang
2025-03-25 6:32 ` Kasireddy, Vivek
2025-03-25 6:46 ` Bingbu Cao
2025-03-27 13:40 ` Matthew Wilcox
2025-03-28 6:13 ` Huan Yang
2025-03-19 9:09 ` Gao Xiang
2025-03-20 5:31 ` Christoph Hellwig
2025-03-24 2:22 ` Huan Yang
2025-03-24 2:57 ` Matthew Wilcox
2025-03-17 6:26 ` Huan Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312061836.GA12841@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bingbu.cao@linux.intel.com \
--cc=link@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=opensource.kernel@vivo.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=urezki@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.