From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: Alexey Kashavkin <akashavkin@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nft_exthdr: fix offset with ipv4_find_option()
Date: Wed, 12 Mar 2025 15:16:50 +0100 [thread overview]
Message-ID: <20250312141650.GB17121@breakpoint.cc> (raw)
In-Reply-To: <20250312091540.GA15366@breakpoint.cc>
Florian Westphal <fw@strlen.de> wrote:
> Alexey Kashavkin <akashavkin@gmail.com> wrote:
> > There is an incorrect calculation in the offset variable which causes the nft_skb_copy_to_reg() function to always return -EFAULT. Adding the start variable is redundant. In the __ip_options_compile() function the correct offset is specified when finding the function. There is no need to add the size of the iphdr structure to the offset.
>
> Fixes: dbb5281a1f84 ("netfilter: nf_tables: add support for matching IPv4 options")
Patch is fine,
Reviewed-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2025-03-12 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 21:14 [PATCH] netfilter: nft_exthdr: fix offset with ipv4_find_option() Alexey Kashavkin
2025-03-01 22:04 ` Alexey Kashavkin
2025-03-13 12:41 ` Alexey Kashavkin
2025-03-12 9:15 ` Florian Westphal
2025-03-12 13:56 ` Alexey Kashavkin
2025-03-12 14:16 ` Florian Westphal
2025-03-12 14:16 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312141650.GB17121@breakpoint.cc \
--to=fw@strlen.de \
--cc=akashavkin@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.