From: Florian Westphal <fw@strlen.de>
To: Corubba Smith <corubba@gmx.de>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd2,v2 3/6] ulogd: raise error on unknown config key
Date: Wed, 12 Mar 2025 19:55:18 +0100 [thread overview]
Message-ID: <20250312185518.GA4233@breakpoint.cc> (raw)
In-Reply-To: <ccf47d9d-c620-418d-8143-589340802f70@gmx.de>
Corubba Smith <corubba@gmx.de> wrote:
> So my proposed fix would be:
>
> - strncpy(&config_errce->key[0], wordbuf, CONFIG_KEY_LEN - 1);
> + memcpy(&config_errce->key[0], wordbuf, sizeof(config_errce->key) - 1);
>
> Compiles without a warning, and tested to work as expected. Would you
> like a v3 of the whole patch, or is this addendum good enough?
Please rebase and send a v3.
next prev parent reply other threads:[~2025-03-12 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 14:52 [PATCH ulogd2,v2 1/6] ulogd: add ulogd_parse_configfile public function Corubba Smith
2025-03-12 14:53 ` [PATCH ulogd2,v2 2/6] all: use config_parse_file function in all plugins Corubba Smith
2025-03-12 14:54 ` [PATCH ulogd2,v2 3/6] ulogd: raise error on unknown config key Corubba Smith
2025-03-12 15:21 ` Florian Westphal
2025-03-12 18:48 ` Corubba Smith
2025-03-12 18:55 ` Florian Westphal [this message]
2025-03-12 14:55 ` [PATCH ulogd2,v2 4/6] ulogd: improve integer option parsing Corubba Smith
2025-03-12 14:55 ` [PATCH ulogd2,v2 5/6] ulogd: provide default configure implementation Corubba Smith
2025-03-12 14:56 ` [PATCH ulogd2,v2 6/6] all: remove trivial configure hooks Corubba Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312185518.GA4233@breakpoint.cc \
--to=fw@strlen.de \
--cc=corubba@gmx.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.