From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_conntrack: speed up reads from nf_conntrack proc file
Date: Wed, 12 Mar 2025 22:39:48 +0100 [thread overview]
Message-ID: <20250312213948.GC4233@breakpoint.cc> (raw)
In-Reply-To: <Z9HkUgJgQBHXrR6Z@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > 2. skip to next and miss an entry
>
> I think we can still display duplicates in 2. too since nulls check if
> the iteration finished on another bucket? Then 2. means skipped
> entries and duplicates.
Yes, but its not a change in behaviour, this was never a stable walk.
> > I'm not sure whats worse/better.
>
> Skipping looks simpler, it is less code. But if entries are duplicated
> then userspace has a chance to deduplicate?
Lets just give up and nuke the entire functionality, i.e. /proc
interface removal.
prev parent reply other threads:[~2025-03-12 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 13:03 [PATCH nf-next] netfilter: nf_conntrack: speed up reads from nf_conntrack proc file Florian Westphal
2025-03-12 16:54 ` Pablo Neira Ayuso
2025-03-12 18:28 ` Florian Westphal
2025-03-12 19:45 ` Pablo Neira Ayuso
2025-03-12 21:39 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312213948.GC4233@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.