From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB2D1C282DE for ; Thu, 13 Mar 2025 14:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i0EPWb+JkHgxI+PRdLg9DkxK50vDKVLPzwtq+0ry8ho=; b=fg6yr+COoMI8uO 6pZkpEyAXDKe2hwbLzMtGRptTFJp1IICNpQ2EnLIo056dSb2ygdEFAbmgw1zb94pv4w/fS4e5cGD1 wIh2MxgzwLCFqdpiBwRPKUVI+ouL5HRMQzTUWkzftgE4ybhSBK4hlWtY8FD/Z0bxfx1s9dDNJKHJD TjSLmCGjIPBY8Suo9/vptl5Lwajdfb3lTJ9BjMAfy3Urb+eEWfZ1pcWYcScE7ZxeoLXaK+U4wQP1n fzr3R4vn/t1MpXjsWP0nm9BHuBZVntxN2Mu/wtI/GTFNih7uOze4zHb02f289L/hHRSqfk/lpYTXS OyinfgXcIJnakyah01ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsjtg-0000000BaIa-1dN0; Thu, 13 Mar 2025 14:50:56 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tshvC-0000000BHBm-3wbB for kvm-riscv@bombadil.infradead.org; Thu, 13 Mar 2025 12:44:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=B82xc6SVqOd2WbuINoOfzR3c47 4IgFNkY7pxfmu6CGSk0Los9xe+21qNh7dxIdrLaf5gZh2+OWQCTrqaqNumhUUHLusss+CwZjR2YhZ g6jlaYHiHOLZUXkIpu/4Q1odSjj7Bu5fZSw35IlfxK+OU2n3P732A17jzJCugT4bju4FhwJwsCW3y NgOGEvMHEdT9jHV5ZPdraSAY21bKruM0bfbGlsYRFjQgnouYul+TQqSyMJf1TWqVYqcOraRUc7K/w u3H+grmD0/CrmPi9LvXgIfktxTzRqV0QlxaiGCJTOxZjB78Qe9i2qBSDJ7YXVKbmHwKCGwmTxNDiz /29jUR+A==; Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tshv9-00000002cP3-3P53 for kvm-riscv@lists.infradead.org; Thu, 13 Mar 2025 12:44:21 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-39129fc51f8so785992f8f.0 for ; Thu, 13 Mar 2025 05:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1741869857; x=1742474657; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=jbTcCO4AR+HYvwXEAE2dDtDOIJATqlS/f01V2Aq4hnLK5dsY74KvcU+/f3sOSdq2dd fgEhUQwKUo+Sy+LjaHyGlgab1zLufjQsqolhJ1uDNM0cYNHrSXRTunwlAv9xq66txKDD MzxqYX4VCtVT3RshfJW0ArdBe4FWEum4bbb2I7hrnRt5/ZGSlD1SexPjXhP4Sb0/7CNC +GRGP7ZocH0dbk4DQRKpySUqKbhvRwq7mNksgwAK0hkOtoyidJyp3EYp6mxbY6UCz0Hd 2ggWy4Pd8aw7owihvDoc+m9yfKhIHOLqPfjGNs3hmk28CPJrh1pkUkh0hD7ucNSzl+Dg Nylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741869857; x=1742474657; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=d2dnnLGqTE20dKg5mQt22UsrBxgWJ9zw003RUffYmTmEJyv+vaTigGJNbUdjYnL6jK ejpdtmnQBwmdF4gv1XjaEdWbrKA8VhiLGgfzdamm54SrTWXvuXUAHGdPFS/DllQ0pRt6 qQzdVJmyzOK1bsWiYEbeHAmaRrZcuEoko6Aiz9069gU8sQbKHi06wi04JXVRSxKCcRpO o1qUb4Fj+S8UFg2hoSqu8s7ghEgv+kjjON32o4/HSbOPTwkTpNCrIyIRpchjuz6YtqSW AM3xR3PrO4pwm08JwJwsSaFFawZsLyPQ+dI6iSw32CTf4jXyzKd6Vf4PsoumABluT2ZS 6h4g== X-Forwarded-Encrypted: i=1; AJvYcCXt/sQIfqcP2STtMWKEtIDwQJfkwWqyyFr7A2SZd7qQWJCWUAV6mM7vwrQ4xE4VbNv3sNSyEViDjWI=@lists.infradead.org X-Gm-Message-State: AOJu0Yz2pzEaFe4J/TkIWa8akQV97FQ4K3HonbinbwSP1wtIAnq50N73 fL6xuKG9hGGAv5wDlLVvYOC5WIxwAYYNHI2gxbPvRKaTlKjAo1RDSs6XQotctOg= X-Gm-Gg: ASbGncsPNCrjOzkCTEb2hNYjvAnf35dD9cnuBqadhlCgnr6aqLU8PRUWSCtF7/ZvUrA Y+VNXuawNKt+r0aWYGwmCeHVKmqSj7aK7jwWL7q3wPL+Ty63IO7UPw07Pfe5OxS+TXR19Cf70RA 5GF6riHRK5l5yoYYKgs8zF4JMeVIfA2fReaZyrQh1jpOsiIWeYfNethvHaMKG2fpFTSgeZf1A4H WfF9FvGCAyLfuPbKcwtQT5KGSrxog2QyeSHRkXlhrhMEOtA9Y+hwFll2BdV3mJfjE7FUiXVHjX3 4Vzh8aMOBEVtxh36tQqmCiBUZQc6t6A2RWWj7+sNuSk= X-Google-Smtp-Source: AGHT+IEVKvciONpN7IaLFK/qsTCvmNWqORyhjjKaAjaSuACjOZk+fDyP3VpTM/ig5PwqolpsjOd7kg== X-Received: by 2002:a05:6000:1a87:b0:391:1923:5a91 with SMTP id ffacd0b85a97d-39132dc4395mr17992640f8f.55.1741869857406; Thu, 13 Mar 2025 05:44:17 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::59a5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b6e87sm2097439f8f.32.2025.03.13.05.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 05:44:16 -0700 (PDT) Date: Thu, 13 Mar 2025 13:44:16 +0100 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v3 03/17] riscv: sbi: add SBI FWFT extension calls Message-ID: <20250313-ce439653d16b484dba6a8d3e@orel> References: <20250310151229.2365992-1-cleger@rivosinc.com> <20250310151229.2365992-4-cleger@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310151229.2365992-4-cleger@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_124420_107611_9FC5E653 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Mon, Mar 10, 2025 at 04:12:10PM +0100, Cl=E9ment L=E9ger wrote: > Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is > provided as a separate commit that can be left out if needed. > = > Signed-off-by: Cl=E9ment L=E9ger > --- > arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > = > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index 256910db1307..af8e2199e32d 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -299,9 +299,19 @@ static int __sbi_rfence_v02(int fid, const struct cp= umask *cpu_mask, > return 0; > } > = > +static bool sbi_fwft_supported; > + > int sbi_fwft_get(u32 feature, unsigned long *value) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret =3D sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_GET, > + feature, 0, 0, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); > } > = > /** > @@ -314,7 +324,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value) > */ > int sbi_fwft_set(u32 feature, unsigned long value, unsigned long flags) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret =3D sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_SET, > + feature, value, flags, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); sbi_err_map_linux_errno() doesn't know about SBI_ERR_DENIED_LOCKED. > } > = > struct fwft_set_req { > @@ -389,6 +407,9 @@ static int sbi_fwft_feature_local_set(u32 feature, un= signed long value, > int sbi_fwft_all_cpus_set(u32 feature, unsigned long value, unsigned lon= g flags, > bool revert_on_fail) > { > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > if (feature & SBI_FWFT_GLOBAL_FEATURE_BIT) > return sbi_fwft_set(feature, value, flags); > = > @@ -719,6 +740,11 @@ void __init sbi_init(void) > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available =3D true; > } > + if ((sbi_spec_version >=3D sbi_mk_version(2, 0)) && Should check sbi_mk_version(3, 0) > + (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { > + pr_info("SBI FWFT extension detected\n"); > + sbi_fwft_supported =3D true; > + } > } else { > __sbi_set_timer =3D __sbi_set_timer_v01; > __sbi_send_ipi =3D __sbi_send_ipi_v01; > -- = > 2.47.2 > Thanks, drew -- = kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2996B26659C for ; Thu, 13 Mar 2025 12:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741869861; cv=none; b=i/qDlqOQnfQB/v/WaoFy9eBMgrFg1YNtN1/eVzGEYjcV+kOUk8aIyfLhBgAY+LsEPzZ6y2FvmNmTjmiglRzopciPZRKTsmLeAlzkMV4oLV/gMQps+owOsiWP5O7wrahRQRyZj9VddyjpB6JQDqSHJIcRsWAWvfqkA93mkG34ulg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741869861; c=relaxed/simple; bh=EleUDN0p7TORHE0wSEwSE0kj+mfdR9PO/rSWsPpYYTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C931trAEHRiUWgePGEs8EHqTC3nb1/9wMHJ8sa35D0s1Bjz3DN1zO+eZV5EqDurMjzvB8Yy3b/d01gqCYXjmbJ3BxyINCBLhep12+oBwIpEiYLlhS1nWLYWEbG4/UHi36nmmSHbpUFv/GPhSpKjPBunWZ0Wo0Tew7Z8ZQXm3OSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=o/GrbqLC; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="o/GrbqLC" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3914aba1ce4so736836f8f.2 for ; Thu, 13 Mar 2025 05:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1741869857; x=1742474657; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=o/GrbqLCeyyu8Cw/4q1t9rjSCjvoqeKges7sjFAbL8xsEX4XHQpHVCLphDjin3B9OI bzH0u6lO2okzsgxF40lvXb5ECkMBJO6/cCjV6DKWv6Kglw7bDGRuvSQCrUntcbN9VjSS nQH0avWE+dP1UHHjTjRQ5e4RlCeU4leL0UL107u6LhJYTBUi7fey8r6o3xMEVgwBW+EB KFjWy39uxnnNuTrhFMFPiOvmuCqxhDcbXQ9U0Y1+4lHLBJ4+IX6f47JFGM0jPYQOYCiy 0VBR2fo1zX4/RvWsoHbsxtYsWV8x+Ja7FTK46XSHdb4t66myUDN/WnJX6+2lVUWsnuei WYpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741869857; x=1742474657; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=dhevCIEX5NmcNN5ZKqJLypBNiftjvw+oM8hRIECZLXFUxbFMy2la4xnvJEeArVhfyx QYns6J9uaFqvCp5rIruIDFMnIwu2Gk+Mbm7qssVBMf5r+rmroOUXiZmuwZyClHwSAmIk fuNK8qYF6q99o4uHaZuPz6sjOmgeE+OKwX5rWkOvAxogqRaJmOTv1FAdRMbEz1yTqHJu SwA3OOK3gejqtGOiGpAzv0C3TNeNoN0XJ52/gleiZVvS9ZRd1BtX8P5fnrrQHrAe/9sX 8NYpIDM7PnXYC1Zhs6En779AMAc2h2akv+39olONlas0OG1qiLBRRlUJ7Y2hXoEMvQzc 1O/A== X-Forwarded-Encrypted: i=1; AJvYcCVsSF3ZObEG+XtMygR9ZZgfACV8itdINf16Ca1eDRYnn9VCU8147bfJLZUobgyOFLKQB+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzcR4N2gyrDFaFU3RdyFPvSW9znZ3ovrm8IVxZyHqdSN37IY2SV 9uBlHhBSuWFOgDVtQUlfT7I+6EWhRxvFmqlgtnrzYOOsgyABrsMROgiWiDqaPrY= X-Gm-Gg: ASbGnctSj7K7eCDZyvBk0D/4S9xhDOZe7OXarC+sQVuGG/FTMESwpVDMrZgBfTAYUOm BJeVdVH6Cngq4aUFYV4dWmYc1//37LFoID7Tla5mTxI/qpiJJsZ8dkVWBKbt0pYUT89HJIVpD6d 89PgOtw1mlUAlNb77i4ns3KcppXOQK1iStinzGCOtv+mjAfSw/C/HQ/hXpio30pDKSsUP8OZV7f CFe02r1RSWGa40AzysnuxM6+zYC+xB4kJJxJjHaLOXaXaR5oR5p6iK+5lylmdPP0HMzvk52+XhL YGxLaexE4+QZOWCjoxKEnnH0U6rN8ae3nj2cIw5FAoU= X-Google-Smtp-Source: AGHT+IEVKvciONpN7IaLFK/qsTCvmNWqORyhjjKaAjaSuACjOZk+fDyP3VpTM/ig5PwqolpsjOd7kg== X-Received: by 2002:a05:6000:1a87:b0:391:1923:5a91 with SMTP id ffacd0b85a97d-39132dc4395mr17992640f8f.55.1741869857406; Thu, 13 Mar 2025 05:44:17 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::59a5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b6e87sm2097439f8f.32.2025.03.13.05.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 05:44:16 -0700 (PDT) Date: Thu, 13 Mar 2025 13:44:16 +0100 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v3 03/17] riscv: sbi: add SBI FWFT extension calls Message-ID: <20250313-ce439653d16b484dba6a8d3e@orel> References: <20250310151229.2365992-1-cleger@rivosinc.com> <20250310151229.2365992-4-cleger@rivosinc.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250310151229.2365992-4-cleger@rivosinc.com> On Mon, Mar 10, 2025 at 04:12:10PM +0100, Clément Léger wrote: > Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is > provided as a separate commit that can be left out if needed. > > Signed-off-by: Clément Léger > --- > arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index 256910db1307..af8e2199e32d 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -299,9 +299,19 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, > return 0; > } > > +static bool sbi_fwft_supported; > + > int sbi_fwft_get(u32 feature, unsigned long *value) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret = sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_GET, > + feature, 0, 0, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); > } > > /** > @@ -314,7 +324,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value) > */ > int sbi_fwft_set(u32 feature, unsigned long value, unsigned long flags) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret = sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_SET, > + feature, value, flags, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); sbi_err_map_linux_errno() doesn't know about SBI_ERR_DENIED_LOCKED. > } > > struct fwft_set_req { > @@ -389,6 +407,9 @@ static int sbi_fwft_feature_local_set(u32 feature, unsigned long value, > int sbi_fwft_all_cpus_set(u32 feature, unsigned long value, unsigned long flags, > bool revert_on_fail) > { > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > if (feature & SBI_FWFT_GLOBAL_FEATURE_BIT) > return sbi_fwft_set(feature, value, flags); > > @@ -719,6 +740,11 @@ void __init sbi_init(void) > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available = true; > } > + if ((sbi_spec_version >= sbi_mk_version(2, 0)) && Should check sbi_mk_version(3, 0) > + (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { > + pr_info("SBI FWFT extension detected\n"); > + sbi_fwft_supported = true; > + } > } else { > __sbi_set_timer = __sbi_set_timer_v01; > __sbi_send_ipi = __sbi_send_ipi_v01; > -- > 2.47.2 > Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 122EFC282DE for ; Thu, 13 Mar 2025 14:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LYEtZHeqBhLODPt0jwjeZAMVNTMj7N8ABazCKahSl10=; b=QEx2G1Z1W9UA0U sPeqo/zHkqaApSNKrbAEYaeYa1WMfKhJ+K6q1gmq/Ydcagr98D3Y3rTGSh/xl/UWr8e//3pKXzUWU 1d98l2RjFVw6c9r3kK9kEEalLK1ArOh7d2hQ3pgj9viSsQcNkyVYyU5uSXGeW4bkWqMZ021m6nHNd 74jdFvHj3sSchpc13LmIOE9wnFbpjekG0WPJoNUlO3dp4klYET+tF6uqYif3TWzcILgx6IFwvzmNY UZ+eECTKK6GLu2aPTJ5Lb2wL4fIIn+vgojCKvyLQe9B1wlO7PLcqy1QSDgtV9BFrifpunPSJNkN+P flKm3saSQTOuqQrhrfbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsjtf-0000000BaIG-3cao; Thu, 13 Mar 2025 14:50:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tshvC-0000000BHBl-3rCB for linux-riscv@bombadil.infradead.org; Thu, 13 Mar 2025 12:44:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=B82xc6SVqOd2WbuINoOfzR3c47 4IgFNkY7pxfmu6CGSk0Los9xe+21qNh7dxIdrLaf5gZh2+OWQCTrqaqNumhUUHLusss+CwZjR2YhZ g6jlaYHiHOLZUXkIpu/4Q1odSjj7Bu5fZSw35IlfxK+OU2n3P732A17jzJCugT4bju4FhwJwsCW3y NgOGEvMHEdT9jHV5ZPdraSAY21bKruM0bfbGlsYRFjQgnouYul+TQqSyMJf1TWqVYqcOraRUc7K/w u3H+grmD0/CrmPi9LvXgIfktxTzRqV0QlxaiGCJTOxZjB78Qe9i2qBSDJ7YXVKbmHwKCGwmTxNDiz /29jUR+A==; Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tshv9-00000002cP4-3OKb for linux-riscv@lists.infradead.org; Thu, 13 Mar 2025 12:44:21 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-391342fc1f6so820541f8f.1 for ; Thu, 13 Mar 2025 05:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1741869857; x=1742474657; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=jbTcCO4AR+HYvwXEAE2dDtDOIJATqlS/f01V2Aq4hnLK5dsY74KvcU+/f3sOSdq2dd fgEhUQwKUo+Sy+LjaHyGlgab1zLufjQsqolhJ1uDNM0cYNHrSXRTunwlAv9xq66txKDD MzxqYX4VCtVT3RshfJW0ArdBe4FWEum4bbb2I7hrnRt5/ZGSlD1SexPjXhP4Sb0/7CNC +GRGP7ZocH0dbk4DQRKpySUqKbhvRwq7mNksgwAK0hkOtoyidJyp3EYp6mxbY6UCz0Hd 2ggWy4Pd8aw7owihvDoc+m9yfKhIHOLqPfjGNs3hmk28CPJrh1pkUkh0hD7ucNSzl+Dg Nylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741869857; x=1742474657; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p4eBilR3cQKKkUL6iTV1U2gPm+aqkc/I2/ErCrbp51A=; b=Pj2xL0jWy9jWQnjDhBFwNYozfbJ0vpYOcrQEsipZMpRkLmlnyjxSfHdJLOUy4geW2W VChpZiSs+FfMRmKAjbn5fUe961F+3IPs8ASgdV+NiW79Z24nqzo3SZgHBoTnxbSAek+L KnEZAXqLm8V6/SH3YLBLeHVky/uyQgyQcsHUBZCf9Ht7R+h1LXxtcXA2h1h/3W8kX/l9 SwBvrdsKczGCeKuVn9wd7KFVW3SOxZIOpxXSRQgVglppX5M1U/bVRRugTekooGwMbcdj 7y2tb+EUvhQ3AYB+D4ie25BmbwoQwG0LMc8F1xu298Fdc2vL+jSXMzX5htwsNUX586Wa YoLw== X-Forwarded-Encrypted: i=1; AJvYcCX29alghRe6POkCRMkLluRJ1u8q4asX/cfoSycIOTieOk2FMmy/uVfNiFjlomYU7Vt6MnnvjiVyi0FaMg==@lists.infradead.org X-Gm-Message-State: AOJu0Yzxe6z+9N10L3vAFpsCLxniFBdswbik3APlt2WUxkZY+hBznC+/ lissaktQD/gthT2r1y7UVKpCiBsDPpOnR6X0NIZRsFIAqKvgIxeZiu226FGO49Q= X-Gm-Gg: ASbGncvFpJyzCxCaypPGrZz2uRhPR+2a0m0XIo4q1BdwlGT9MX9ZB4boVqpooXd2f5z 898ZwxvE8Y9Y9sZ51EltliiFzj85qSaUdymKrUaiJg7M551X6vXSv/El+7YdWvyoYecV+uV4w4P rSfAm7raRBt4IshrH0fG6tTh6ONfRC2Wz2wJ9JTvNhot7GeqricXfprot7TNJemBMlDYmSpdJpD G6VHqwZMHXeOvEgb8erdQZOTNsc3hkayEnlchAzs7afmbmorG6yCyFEcLdizdGhQz/X/LqD+QoB zpE7onRnwAc1uW90s2XUs5WBuhZU9xcRyvZpgXBhxr4= X-Google-Smtp-Source: AGHT+IEVKvciONpN7IaLFK/qsTCvmNWqORyhjjKaAjaSuACjOZk+fDyP3VpTM/ig5PwqolpsjOd7kg== X-Received: by 2002:a05:6000:1a87:b0:391:1923:5a91 with SMTP id ffacd0b85a97d-39132dc4395mr17992640f8f.55.1741869857406; Thu, 13 Mar 2025 05:44:17 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::59a5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b6e87sm2097439f8f.32.2025.03.13.05.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 05:44:16 -0700 (PDT) Date: Thu, 13 Mar 2025 13:44:16 +0100 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v3 03/17] riscv: sbi: add SBI FWFT extension calls Message-ID: <20250313-ce439653d16b484dba6a8d3e@orel> References: <20250310151229.2365992-1-cleger@rivosinc.com> <20250310151229.2365992-4-cleger@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250310151229.2365992-4-cleger@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_124420_107653_98821FC1 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Mar 10, 2025 at 04:12:10PM +0100, Cl=E9ment L=E9ger wrote: > Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is > provided as a separate commit that can be left out if needed. > = > Signed-off-by: Cl=E9ment L=E9ger > --- > arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > = > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index 256910db1307..af8e2199e32d 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -299,9 +299,19 @@ static int __sbi_rfence_v02(int fid, const struct cp= umask *cpu_mask, > return 0; > } > = > +static bool sbi_fwft_supported; > + > int sbi_fwft_get(u32 feature, unsigned long *value) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret =3D sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_GET, > + feature, 0, 0, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); > } > = > /** > @@ -314,7 +324,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value) > */ > int sbi_fwft_set(u32 feature, unsigned long value, unsigned long flags) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret =3D sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_SET, > + feature, value, flags, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); sbi_err_map_linux_errno() doesn't know about SBI_ERR_DENIED_LOCKED. > } > = > struct fwft_set_req { > @@ -389,6 +407,9 @@ static int sbi_fwft_feature_local_set(u32 feature, un= signed long value, > int sbi_fwft_all_cpus_set(u32 feature, unsigned long value, unsigned lon= g flags, > bool revert_on_fail) > { > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > if (feature & SBI_FWFT_GLOBAL_FEATURE_BIT) > return sbi_fwft_set(feature, value, flags); > = > @@ -719,6 +740,11 @@ void __init sbi_init(void) > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available =3D true; > } > + if ((sbi_spec_version >=3D sbi_mk_version(2, 0)) && Should check sbi_mk_version(3, 0) > + (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { > + pr_info("SBI FWFT extension detected\n"); > + sbi_fwft_supported =3D true; > + } > } else { > __sbi_set_timer =3D __sbi_set_timer_v01; > __sbi_send_ipi =3D __sbi_send_ipi_v01; > -- = > 2.47.2 > Thanks, drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv