All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: gregkh@linuxfoundation.org, rafael@kernel.org,
	bhelgaas@google.com, ojeda@kernel.org, alex.gaynor@gmail.com,
	boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
	benno.lossin@proton.me, a.hindborg@kernel.org,
	aliceryhl@google.com, tmgross@umich.edu
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	rust-for-linux@vger.kernel.org,
	Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH 1/4] rust: pci: use to_result() in enable_device_mem()
Date: Thu, 13 Mar 2025 03:13:31 +0100	[thread overview]
Message-ID: <20250313021550.133041-2-dakr@kernel.org> (raw)
In-Reply-To: <20250313021550.133041-1-dakr@kernel.org>

Simplify enable_device_mem() by using to_result() to handle the return
value of the corresponding FFI call.

Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 rust/kernel/pci.rs | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index 4c98b5b9aa1e..386484dcf36e 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -382,12 +382,7 @@ pub fn device_id(&self) -> u16 {
     /// Enable memory resources for this device.
     pub fn enable_device_mem(&self) -> Result {
         // SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
-        let ret = unsafe { bindings::pci_enable_device_mem(self.as_raw()) };
-        if ret != 0 {
-            Err(Error::from_errno(ret))
-        } else {
-            Ok(())
-        }
+        to_result(unsafe { bindings::pci_enable_device_mem(self.as_raw()) })
     }
 
     /// Enable bus-mastering for this device.
-- 
2.48.1


  reply	other threads:[~2025-03-13  2:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  2:13 [PATCH 0/4] Improve soundness of bus device abstractions Danilo Krummrich
2025-03-13  2:13 ` Danilo Krummrich [this message]
2025-03-13 10:21   ` [PATCH 1/4] rust: pci: use to_result() in enable_device_mem() Benno Lossin
2025-03-13  2:13 ` [PATCH 2/4] rust: device: implement device context marker Danilo Krummrich
2025-03-13 10:29   ` Benno Lossin
2025-03-13 10:41     ` Danilo Krummrich
2025-03-13 10:52       ` Benno Lossin
2025-03-13 14:20         ` Danilo Krummrich
2025-03-13 14:31           ` Benno Lossin
2025-03-13 10:47     ` Benno Lossin
2025-03-13  2:13 ` [PATCH 3/4] rust: pci: fix unrestricted &mut pci::Device Danilo Krummrich
2025-03-13 10:44   ` Benno Lossin
2025-03-13 14:25     ` Danilo Krummrich
2025-03-13 14:30       ` Benno Lossin
2025-03-13  2:13 ` [PATCH 4/4] rust: platform: fix unrestricted &mut platform::Device Danilo Krummrich
2025-03-13 10:49   ` Benno Lossin
2025-03-13 14:28     ` Danilo Krummrich
2025-03-13 14:41       ` Benno Lossin
2025-03-13  6:08 ` [PATCH 0/4] Improve soundness of bus device abstractions Boqun Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313021550.133041-2-dakr@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.