From: Stefan Hajnoczi <stefanha@redhat.com>
To: zoudongjie <zoudongjie@huawei.com>
Cc: zhuyangyang14@huawei.com, qemu-devel@nongnu.org, fam@euphon.net,
hreitz@redhat.com, qemu-block@nongnu.org, qemu-stable@nongnu.org,
luolongmin@huawei.com, suxiaodong1@huawei.com,
wangyan122@huawei.com, yebiaoxiang@huawei.com,
wangjian161@huawei.com, mujinsheng@huawei.com,
alex.chen@huawei.com, eric.fangyi@huawei.com,
chenjianfei3@huawei.com, renxuming@huawei.com
Subject: Re: [PATCH 0/2] qapi: Fix qmp_block_set_io_throttle blocked for too long
Date: Thu, 13 Mar 2025 12:27:19 +0800 [thread overview]
Message-ID: <20250313042719.GE1074020@fedora> (raw)
In-Reply-To: <20250308101618.721954-1-zoudongjie@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
The idea of adding a timeout parameter sounds good to me.
I think it's safe to call bdrv_drained_end() after the timeout fails,
but I'm not 100% sure. Maybe Kevin has thoughts on this.
I left comments on the patches.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-03-13 7:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 10:16 [PATCH 0/2] qapi: Fix qmp_block_set_io_throttle blocked for too long zoudongjie via
2025-03-08 10:16 ` [PATCH 1/2] io/block: Refactoring the bdrv_drained_begin() function and implement a timeout mechanism zoudongjie via
2025-03-13 4:09 ` Stefan Hajnoczi
2025-03-17 12:18 ` zoudongjie via
2025-03-17 14:57 ` Stefan Hajnoczi
2025-03-13 4:22 ` Stefan Hajnoczi
2025-03-08 10:16 ` [PATCH 2/2] qapi: Fix qmp_block_set_io_throttle blocked for too long zoudongjie via
2025-03-13 4:25 ` Stefan Hajnoczi
2025-03-17 12:59 ` zoudongjie via
2025-03-11 3:24 ` [PATCH 0/2] " zoudongjie via
2025-03-13 4:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313042719.GE1074020@fedora \
--to=stefanha@redhat.com \
--cc=alex.chen@huawei.com \
--cc=chenjianfei3@huawei.com \
--cc=eric.fangyi@huawei.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=luolongmin@huawei.com \
--cc=mujinsheng@huawei.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=renxuming@huawei.com \
--cc=suxiaodong1@huawei.com \
--cc=wangjian161@huawei.com \
--cc=wangyan122@huawei.com \
--cc=yebiaoxiang@huawei.com \
--cc=zhuyangyang14@huawei.com \
--cc=zoudongjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.