From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: chaitanyak@nvidia.com, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me, joao.m.martins@oracle.com,
linux-nvme@lists.infradead.org, kvm@vger.kernel.org,
kwankhede@nvidia.com, alex.williamson@redhat.com,
mlevitsk@redhat.com
Subject: Re: [PATCH RFC 01/11] nvmet: Remove duplicate uuid_copy
Date: Thu, 13 Mar 2025 07:36:12 +0100 [thread overview]
Message-ID: <20250313063612.GA9967@lst.de> (raw)
In-Reply-To: <20250313052222.178524-2-michael.christie@oracle.com>
On Thu, Mar 13, 2025 at 12:18:02AM -0500, Mike Christie wrote:
> We do uuid_copy twice in nvmet_alloc_ctrl so this patch deletes one
> of the calls.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Can you send this separately for inclusion?
next prev parent reply other threads:[~2025-03-13 6:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 5:18 [PATCH RFC 00/11] nvmet: Add NVMe target mdev/vfio driver Mike Christie
2025-03-13 5:18 ` [PATCH RFC 01/11] nvmet: Remove duplicate uuid_copy Mike Christie
2025-03-13 6:36 ` Christoph Hellwig [this message]
2025-03-13 8:59 ` Damien Le Moal
2025-03-13 17:20 ` Keith Busch
2025-03-13 5:18 ` [PATCH RFC 02/11] nvmet: Export nvmet_add_async_event and add definitions Mike Christie
2025-03-13 6:36 ` Christoph Hellwig
2025-03-13 17:50 ` Mike Christie
2025-03-13 5:18 ` [PATCH RFC 03/11] nvmet: Add nvmet_fabrics_ops flag to indicate SGLs not supported Mike Christie
2025-03-13 6:37 ` Christoph Hellwig
2025-03-13 9:02 ` Damien Le Moal
2025-03-13 9:13 ` Christoph Hellwig
2025-03-13 9:16 ` Damien Le Moal
2025-03-13 17:19 ` Mike Christie
2025-03-13 5:18 ` [PATCH RFC 04/11] nvmet: Add function to get nvmet_fabrics_ops from trtype Mike Christie
2025-03-13 9:03 ` Damien Le Moal
2025-03-13 5:18 ` [PATCH RFC 05/11] nvmet: Add function to print trtype Mike Christie
2025-03-13 5:18 ` [PATCH RFC 06/11] nvmet: Allow nvmet_alloc_ctrl users to specify the cntlid Mike Christie
2025-03-13 5:18 ` [PATCH RFC 07/11] nvmet: Add static controller support to configfs Mike Christie
2025-03-13 5:18 ` [PATCH RFC 08/11] nvmet: Add shadow doorbell support Mike Christie
2025-03-13 5:18 ` [PATCH RFC 09/11] nvmet: Add helpers to find and get static controllers Mike Christie
2025-03-13 5:18 ` [PATCH RFC 10/11] nvmet: Add addr fam and trtype for mdev pci driver Mike Christie
2025-03-13 6:42 ` Christoph Hellwig
2025-03-13 17:56 ` Mike Christie
2025-03-13 5:18 ` [PATCH RFC 11/11] nvmet: Add nvmet-mdev-pci driver Mike Christie
2025-03-14 7:32 ` kernel test robot
2025-03-13 5:32 ` [PATCH RFC 00/11] nvmet: Add NVMe target mdev/vfio driver Damien Le Moal
2025-03-13 6:47 ` Christoph Hellwig
2025-03-13 17:17 ` Mike Christie
2025-03-14 8:31 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313063612.GA9967@lst.de \
--to=hch@lst.de \
--cc=alex.williamson@redhat.com \
--cc=chaitanyak@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=kbusch@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=michael.christie@oracle.com \
--cc=mlevitsk@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.