From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvmet: pci-epf: Remove nvmet_pci_epf_[un]map_queue()
Date: Thu, 13 Mar 2025 09:10:05 +0100 [thread overview]
Message-ID: <20250313081004.GA12988@lst.de> (raw)
In-Reply-To: <20250313075814.1442096-1-dlemoal@kernel.org>
On Thu, Mar 13, 2025 at 04:58:14PM +0900, Damien Le Moal wrote:
> The functions nvmet_pci_epf_map_queue() and nvmet_pci_epf_unmap_queue()
> are called respectively only from nvmet_pci_epf_create_cq() and
> nvmet_pci_epf_delete_cq(). Remove these functions and open-code them in
> their call site.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>
> Note: this goes on top of the patch "nvmet: pci-epf: Keep completion
> queues mapped". I can squash these 2 patches together if preferred.
Yes, I think just squashing them would be best.
prev parent reply other threads:[~2025-03-13 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 7:58 [PATCH] nvmet: pci-epf: Remove nvmet_pci_epf_[un]map_queue() Damien Le Moal
2025-03-13 8:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313081004.GA12988@lst.de \
--to=hch@lst.de \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.