Re: [LTP] [PATCH] unshare01: add EINVAL check

[Petr Vorel <pvorel@suse.cz>]

Hi lufei,

Please next time have a look on other tests, if the same thing is already
being tested or not.  EINVAL is already tested in unshare02.c (as -1).

That's why is this patch not needed (if really high value should be tested,
which I don't think so, it should be in unshare02.c).

Also, we try to not mixing positive tests (e.g. CLONE_FILES) with negative ones
(e.g. EINVAL), we put negative to separate test.

> ---
>  testcases/kernel/syscalls/unshare/unshare01.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)

> diff --git a/testcases/kernel/syscalls/unshare/unshare01.c b/testcases/kernel/syscalls/unshare/unshare01.c
> index 6e6315b11..ce1ed2e14 100644
> --- a/testcases/kernel/syscalls/unshare/unshare01.c
> +++ b/testcases/kernel/syscalls/unshare/unshare01.c
> @@ -28,21 +28,30 @@
>  #include "config.h"

>  #ifdef HAVE_UNSHARE
> +#define INV_FLAG 0x0123
> +

>  static struct test_case_t {
>  	int mode;
>  	const char *desc;
> +	const int eno;
nit: "eno" is not much descriptive, we usually use exp_errno.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp