From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Talel Shenhar" <talel@amazon.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Guo Ren" <guoren@kernel.org>,
"Herve Codina" <herve.codina@bootlin.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>
Subject: [patch 5/7] gpio: mvebu: Convert generic irqchip locking to guard()
Date: Thu, 13 Mar 2025 15:31:25 +0100 (CET) [thread overview]
Message-ID: <20250313142524.262678485@linutronix.de> (raw)
In-Reply-To: 20250313142404.896902416@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
---
drivers/gpio/gpio-mvebu.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -407,9 +407,8 @@ static void mvebu_gpio_irq_ack(struct ir
struct mvebu_gpio_chip *mvchip = gc->private;
u32 mask = d->mask;
- irq_gc_lock(gc);
+ guard(raw_spinlock)(&gc->lock);
mvebu_gpio_write_edge_cause(mvchip, ~mask);
- irq_gc_unlock(gc);
}
static void mvebu_gpio_edge_irq_mask(struct irq_data *d)
@@ -419,10 +418,9 @@ static void mvebu_gpio_edge_irq_mask(str
struct irq_chip_type *ct = irq_data_get_chip_type(d);
u32 mask = d->mask;
- irq_gc_lock(gc);
+ guard(raw_spinlock)(&gc->lock);
ct->mask_cache_priv &= ~mask;
mvebu_gpio_write_edge_mask(mvchip, ct->mask_cache_priv);
- irq_gc_unlock(gc);
}
static void mvebu_gpio_edge_irq_unmask(struct irq_data *d)
@@ -432,11 +430,10 @@ static void mvebu_gpio_edge_irq_unmask(s
struct irq_chip_type *ct = irq_data_get_chip_type(d);
u32 mask = d->mask;
- irq_gc_lock(gc);
+ guard(raw_spinlock)(&gc->lock);
mvebu_gpio_write_edge_cause(mvchip, ~mask);
ct->mask_cache_priv |= mask;
mvebu_gpio_write_edge_mask(mvchip, ct->mask_cache_priv);
- irq_gc_unlock(gc);
}
static void mvebu_gpio_level_irq_mask(struct irq_data *d)
@@ -446,10 +443,9 @@ static void mvebu_gpio_level_irq_mask(st
struct irq_chip_type *ct = irq_data_get_chip_type(d);
u32 mask = d->mask;
- irq_gc_lock(gc);
+ guard(raw_spinlock)(&gc->lock);
ct->mask_cache_priv &= ~mask;
mvebu_gpio_write_level_mask(mvchip, ct->mask_cache_priv);
- irq_gc_unlock(gc);
}
static void mvebu_gpio_level_irq_unmask(struct irq_data *d)
@@ -459,10 +455,9 @@ static void mvebu_gpio_level_irq_unmask(
struct irq_chip_type *ct = irq_data_get_chip_type(d);
u32 mask = d->mask;
- irq_gc_lock(gc);
+ guard(raw_spinlock)(&gc->lock);
ct->mask_cache_priv |= mask;
mvebu_gpio_write_level_mask(mvchip, ct->mask_cache_priv);
- irq_gc_unlock(gc);
}
/*****************************************************************************
next prev parent reply other threads:[~2025-03-13 14:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 14:31 [patch 0/7] genirq/generic_chip: Convert locking to guards Thomas Gleixner
2025-03-13 14:31 ` [patch 1/7] genirq/generic-chip: Make locking unconditional Thomas Gleixner
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-03-13 14:31 ` [patch 2/7] genirq/generic-chip: Convert core code to lock guards Thomas Gleixner
2025-03-14 10:55 ` Linus Walleij
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-04-08 18:10 ` [patch 2/7] " Geert Uytterhoeven
2025-03-13 14:31 ` [patch 3/7] soc: dove: Convert generic irqchip locking to guard() Thomas Gleixner
2025-03-13 14:48 ` Andrew Lunn
2025-03-14 10:57 ` Linus Walleij
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-03-13 14:31 ` [patch 4/7] ARM: orion/gpio:: " Thomas Gleixner
2025-03-14 10:56 ` Linus Walleij
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-04-14 14:29 ` [patch 4/7] " Gregory CLEMENT
2025-03-13 14:31 ` Thomas Gleixner [this message]
2025-03-14 10:19 ` [patch 5/7] gpio: mvebu: " Bartosz Golaszewski
2025-03-14 11:07 ` Linus Walleij
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-03-13 14:31 ` [patch 6/7] irqchip: Convert generic irqchip locking to guards Thomas Gleixner
2025-03-14 10:56 ` Linus Walleij
2025-03-14 17:20 ` Herve Codina
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-03-13 14:31 ` [patch 7/7] genirq/generic-chip: Remove unused lock wrappers Thomas Gleixner
2025-04-07 7:53 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-03-16 8:50 ` [cocci] [patch 0/7] genirq/generic_chip: Convert locking to guards Markus Elfring
2025-03-16 8:50 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313142524.262678485@linutronix.de \
--to=tglx@linutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=florian.fainelli@broadcom.com \
--cc=gregory.clement@bootlin.com \
--cc=guoren@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jirislaby@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=samuel@sholland.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=talel@amazon.com \
--cc=ukleinek@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.