All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: David Sterba <dsterba@suse.cz>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/6] btrfs: prepare for larger folios support
Date: Thu, 13 Mar 2025 16:21:24 +0100	[thread overview]
Message-ID: <20250313152124.GA2420634@ax162> (raw)
In-Reply-To: <20250312134455.GN32661@twin.jikos.cz>

On Wed, Mar 12, 2025 at 02:44:55PM +0100, David Sterba wrote:
> On Mon, Mar 10, 2025 at 06:05:56PM +1030, Qu Wenruo wrote:
> > [CHANGELOG]
> > v2:
> > - Split the subpage.[ch] modification into 3 patches
> > - Rebased the latest for-next branch
> >   Now all dependency are in for-next.
> 
> Please add the series to for-next, I haven't found anything that would
> need fixups or another resend so we cant get it to 6.15 queue. Thanks.

This series is still broken for 32-bit targets as reported two weeks ago:

https://lore.kernel.org/202502211908.aCcQQyEY-lkp@intel.com/
https://lore.kernel.org/20250225184136.GA1679809@ax162/

$ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- mrproper allmodconfig fs/btrfs/extent_io.o
In file included from <command-line>:
fs/btrfs/extent_io.c: In function 'extent_write_locked_range':
include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_802' declared with attribute error: min(folio_pos(folio) + folio_size(folio) - 1, end) signedness error
  557 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
include/linux/compiler_types.h:538:25: note: in definition of macro '__compiletime_assert'
  538 |                         prefix ## suffix();                             \
      |                         ^~~~~~
include/linux/compiler_types.h:557:9: note: in expansion of macro '_compiletime_assert'
  557 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   93 |         BUILD_BUG_ON_MSG(!__types_ok(ux, uy),           \
      |         ^~~~~~~~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
   98 |         __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
      |         ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
  105 | #define min(x, y)       __careful_cmp(min, x, y)
      |                         ^~~~~~~~~~~~~
fs/btrfs/extent_io.c:2472:27: note: in expansion of macro 'min'
 2472 |                 cur_end = min(folio_pos(folio) + folio_size(folio) - 1, end);
      |                           ^~~

Cheers,
Nathan

  reply	other threads:[~2025-03-13 15:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10  7:35 [PATCH v2 0/6] btrfs: prepare for larger folios support Qu Wenruo
2025-03-10  7:35 ` [PATCH 1/6] btrfs: subpage: make btrfs_is_subpage() check against a folio Qu Wenruo
2025-03-10  7:35 ` [PATCH 2/6] btrfs: add a @fsize parameter to btrfs_alloc_subpage() Qu Wenruo
2025-03-10  7:35 ` [PATCH 3/6] btrfs: replace PAGE_SIZE with folio_size for subpage.[ch] Qu Wenruo
2025-03-10  7:36 ` [PATCH 4/6] btrfs: prepare btrfs_launcher_folio() for larger folios support Qu Wenruo
2025-03-10  7:36 ` [PATCH 5/6] btrfs: prepare extent_io.c for future larger folio support Qu Wenruo
2025-03-10 23:27   ` Boris Burkov
2025-03-10 23:51     ` Qu Wenruo
2025-03-10  7:36 ` [PATCH 6/6] btrfs: prepare btrfs_page_mkwrite() for larger folios Qu Wenruo
2025-03-10 23:32 ` [PATCH v2 0/6] btrfs: prepare for larger folios support Boris Burkov
2025-03-10 23:56   ` Qu Wenruo
2025-03-11 10:25 ` Johannes Thumshirn
2025-03-12 13:44 ` David Sterba
2025-03-13 15:21   ` Nathan Chancellor [this message]
2025-03-13 20:50     ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313152124.GA2420634@ax162 \
    --to=nathan@kernel.org \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.