Re: [PATCH wireless-next v5 04/11] wifi: cfg80211: reorg sinfo structure elements for MLO

[kernel test robot <lkp@intel.com>]

Hi Sarika,

kernel test robot noticed the following build errors:

[auto build test ERROR on 9324731b9985478faf7f77713cc5e5fee811716e]

url:    https://github.com/intel-lab-lkp/linux/commits/Sarika-Sharma/wifi-mac80211-add-support-towards-MLO-handling-of-station-statistics/20250312-145356
base:   9324731b9985478faf7f77713cc5e5fee811716e
patch link:    https://lore.kernel.org/r/20250312065132.3397726-5-quic_sarishar%40quicinc.com
patch subject: [PATCH wireless-next v5 04/11] wifi: cfg80211: reorg sinfo structure elements for MLO
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250313/202503131646.3EOj6ycs-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250313/202503131646.3EOj6ycs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503131646.3EOj6ycs-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:12:
   drivers/net/wireless/intel/iwlwifi/mld/iface.h:172:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0 [-Wundef]
     172 | #if CONFIG_PM_SLEEP
         |     ^~~~~~~~~~~~~~~
>> drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:2637:10: error: 'const struct ieee80211_ops' has no member named 'sta_statistics'; did you mean 'link_sta_statistics'?
    2637 |         .sta_statistics = iwl_mld_mac80211_sta_statistics,
         |          ^~~~~~~~~~~~~~
         |          link_sta_statistics
>> drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:2637:27: error: initialization of 'void (*)(struct ieee80211_hw *, struct ieee80211_vif *, struct ieee80211_sta *)' from incompatible pointer type 'void (*)(struct ieee80211_hw *, struct ieee80211_vif *, struct ieee80211_sta *, struct station_info *)' [-Wincompatible-pointer-types]
    2637 |         .sta_statistics = iwl_mld_mac80211_sta_statistics,
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:2637:27: note: (near initialization for 'iwl_mld_hw_ops.sta_pre_rcu_remove')
   drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:2651:31: warning: initialized field overwritten [-Woverride-init]
    2651 |         .sta_pre_rcu_remove = iwl_mld_sta_pre_rcu_remove,
         |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:2651:31: note: (near initialization for 'iwl_mld_hw_ops.sta_pre_rcu_remove')
   drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:1985:12: warning: 'iwl_mld_resume' defined but not used [-Wunused-function]
    1985 | static int iwl_mld_resume(struct ieee80211_hw *hw)
         |            ^~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:1963:1: warning: 'iwl_mld_suspend' defined but not used [-Wunused-function]
    1963 | iwl_mld_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
         | ^~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/mld/mac80211.c:1949:13: warning: 'iwl_mld_set_wakeup' defined but not used [-Wunused-function]
    1949 | static void iwl_mld_set_wakeup(struct ieee80211_hw *hw, bool enabled)
         |             ^~~~~~~~~~~~~~~~~~
--
   In file included from drivers/net/wireless/intel/iwlwifi/mld/mlo.h:13,
                    from drivers/net/wireless/intel/iwlwifi/mld/stats.c:9:
   drivers/net/wireless/intel/iwlwifi/mld/iface.h:172:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0 [-Wundef]
     172 | #if CONFIG_PM_SLEEP
         |     ^~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/mld/stats.c: In function 'iwl_mld_fill_stats_from_oper_notif':
>> drivers/net/wireless/intel/iwlwifi/mld/stats.c:67:14: error: 'struct station_info' has no member named 'signal_avg'
      67 |         sinfo->signal_avg = mld_link_sta->signal_avg;
         |              ^~
   drivers/net/wireless/intel/iwlwifi/mld/stats.c: In function 'iwl_mld_sta_stats_fill_txrate':
   drivers/net/wireless/intel/iwlwifi/mld/stats.c:169:41: error: 'struct station_info' has no member named 'txrate'
     169 |         struct rate_info *rinfo = &sinfo->txrate;
         |                                         ^~


vim +2637 drivers/net/wireless/intel/iwlwifi/mld/mac80211.c

d1e879ec600f9b3 Miri Korenblit 2025-02-16  2608  
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2609  const struct ieee80211_ops iwl_mld_hw_ops = {
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2610  	.tx = iwl_mld_mac80211_tx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2611  	.start = iwl_mld_mac80211_start,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2612  	.stop = iwl_mld_mac80211_stop,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2613  	.config = iwl_mld_mac80211_config,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2614  	.add_interface = iwl_mld_mac80211_add_interface,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2615  	.remove_interface = iwl_mld_mac80211_remove_interface,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2616  	.conf_tx = iwl_mld_mac80211_conf_tx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2617  	.prepare_multicast = iwl_mld_mac80211_prepare_multicast,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2618  	.configure_filter = iwl_mld_mac80211_configure_filter,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2619  	.reconfig_complete = iwl_mld_mac80211_reconfig_complete,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2620  	.wake_tx_queue = iwl_mld_mac80211_wake_tx_queue,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2621  	.add_chanctx = iwl_mld_add_chanctx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2622  	.remove_chanctx = iwl_mld_remove_chanctx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2623  	.change_chanctx = iwl_mld_change_chanctx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2624  	.assign_vif_chanctx = iwl_mld_assign_vif_chanctx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2625  	.unassign_vif_chanctx = iwl_mld_unassign_vif_chanctx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2626  	.set_rts_threshold = iwl_mld_mac80211_set_rts_threshold,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2627  	.link_info_changed = iwl_mld_mac80211_link_info_changed,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2628  	.vif_cfg_changed = iwl_mld_mac80211_vif_cfg_changed,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2629  	.set_key = iwl_mld_mac80211_set_key,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2630  	.hw_scan = iwl_mld_mac80211_hw_scan,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2631  	.cancel_hw_scan = iwl_mld_mac80211_cancel_hw_scan,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2632  	.sched_scan_start = iwl_mld_mac80211_sched_scan_start,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2633  	.sched_scan_stop = iwl_mld_mac80211_sched_scan_stop,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2634  	.mgd_prepare_tx = iwl_mld_mac80211_mgd_prepare_tx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2635  	.mgd_complete_tx = iwl_mld_mac_mgd_complete_tx,
d1e879ec600f9b3 Miri Korenblit 2025-02-16  2636  	.sta_state = iwl_mld_mac80211_sta_state,
d1e879ec600f9b3 Miri Korenblit 2025-02-16 @2637  	.sta_statistics = iwl_mld_mac80211_sta_statistics,

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki