Re: [PATCH 6.1 07/29] xfs: fix bounds check in xfs_defer_agfl_block()

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 2bed0d82c2f78b91a0a9a5a73da57ee883a0c070

WARNING: Author mismatch between patch and upstream commit:
Backport author: Leah Rumancik<leah.rumancik@gmail.com>
Commit author: Dave Chinner<dchinner@redhat.com>

Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)

Note: The patch differs from the upstream commit:
---
1:  2bed0d82c2f78 ! 1:  aec5f983044b3 xfs: fix bounds check in xfs_defer_agfl_block()
    @@ Metadata
      ## Commit message ##
         xfs: fix bounds check in xfs_defer_agfl_block()
     
    +    [ Upstream commit 2bed0d82c2f78b91a0a9a5a73da57ee883a0c070 ]
    +
         Need to happen before we allocate and then leak the xefi. Found by
         coverity via an xfsprogs libxfs scan.
     
    @@ Commit message
         Reviewed-by: Christoph Hellwig <hch@lst.de>
         Reviewed-by: Darrick J. Wong <djwong@kernel.org>
         Signed-off-by: Darrick J. Wong <djwong@kernel.org>
    +    Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
    +    Acked-by: "Darrick J. Wong" <djwong@kernel.org>
     
      ## fs/xfs/libxfs/xfs_alloc.c ##
     @@ fs/xfs/libxfs/xfs_alloc.c: static int
    @@ fs/xfs/libxfs/xfs_alloc.c: static int
     +	xefi->xefi_startblock = fsbno;
      	xefi->xefi_blockcount = 1;
      	xefi->xefi_owner = oinfo->oi_owner;
    - 	xefi->xefi_agresv = XFS_AG_RESV_AGFL;
      
     -	if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbno(mp, xefi->xefi_startblock)))
     -		return -EFSCORRUPTED;
     -
      	trace_xfs_agfl_free_defer(mp, agno, 0, agbno, 1);
      
    - 	xfs_extent_free_get_group(mp, xefi);
    + 	xfs_defer_add(tp, XFS_DEFER_OPS_TYPE_AGFL_FREE, &xefi->xefi_list);
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y        |  Success    |  Success   |