From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: mingo@redhat.com, tglx@linutronix.de, bp@alien8.de,
acme@kernel.org, namhyung@kernel.org, irogers@google.com,
linux-kernel@vger.kernel.org, ak@linux.intel.com,
eranian@google.com
Subject: Re: [PATCH V9 3/7] perf: attach/detach PMU specific data
Date: Fri, 14 Mar 2025 13:59:58 +0100 [thread overview]
Message-ID: <20250314125958.GC36322@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250314000242.323199-3-kan.liang@linux.intel.com>
On Thu, Mar 13, 2025 at 05:02:38PM -0700, kan.liang@linux.intel.com wrote:
> @@ -12551,6 +12813,14 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
> if (err)
> return ERR_PTR(err);
>
> + if (event->attach_state & PERF_ATTACH_TASK_DATA) {
> + err = attach_perf_ctx_data(event);
> + if (err) {
> + security_perf_event_free(event);
> + return ERR_PTR(err);
> + }
> + }
> +
> /* symmetric to unaccount_event() in _free_event() */
> account_event(event);
>
This seems weird. We just pushed all the error handling into
__free_event(), and now you're adding one special case back.
Also, you've placed it after security_perf_event_alloc(), which I
_think_ wants to be last.
next prev parent reply other threads:[~2025-03-14 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 0:02 [PATCH V9 1/7] perf: Save PMU specific data in task_struct kan.liang
2025-03-14 0:02 ` [PATCH V9 2/7] locking/percpu-rwsem: Add guard support kan.liang
2025-03-14 0:02 ` [PATCH V9 3/7] perf: attach/detach PMU specific data kan.liang
2025-03-14 12:59 ` Peter Zijlstra [this message]
2025-03-14 13:50 ` Liang, Kan
2025-03-14 14:38 ` Liang, Kan
2025-03-14 21:03 ` Peter Zijlstra
2025-03-14 0:02 ` [PATCH V9 4/7] perf: Supply task information to sched_task() kan.liang
2025-03-14 0:02 ` [PATCH V9 5/7] perf/x86/lbr: Fix shorter LBRs call stacks for the system-wide mode kan.liang
2025-03-14 0:02 ` [PATCH V9 6/7] perf/x86: Remove swap_task_ctx() kan.liang
2025-03-14 0:02 ` [PATCH V9 7/7] perf: Clean up pmu specific data kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314125958.GC36322@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.