From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4911FFC48 for ; Fri, 14 Mar 2025 13:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741958924; cv=none; b=Isp6eOT+CEr8fEXOvbuZtVu1Ckq8LBKrqLKOc+g0MYV/uJ29hX4HkJdxWh/FCGJ3opuZLZ294kLHOJckYZaS2yZYKq9HyP21wHCSMhDLo1csq1LoExiWvTYoQRhgHuOZ444pbra1eE9ZOodvSDg7Qj/8m5Y6rd50+Wgq39lPnII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741958924; c=relaxed/simple; bh=aiG1FZnW6ddDhwOKJCjUPzBPtZVwutObpeEgsdc95Yc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=MELlnryGARCono7L6AMLCY09bTZImqU6eU0oKkmjGNyMBfby9tfG/iwiPjH/b0A6AWyzy/V0kuSXVbKc2AuoGq+cXUJqlsu2ewm4peFsRsu6hvHIZGuHDAxNKcvNVEfbUxLdJqaBIWOFbrifZs/fUCsemvWcHvzWhxo1R+7Vnhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TIgTZC2y; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TIgTZC2y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741958922; x=1773494922; h=date:from:to:cc:subject:message-id:mime-version; bh=aiG1FZnW6ddDhwOKJCjUPzBPtZVwutObpeEgsdc95Yc=; b=TIgTZC2ySqNt4rJk0p8wAQxvYXzGO/iJAqsl/KBZVxcl4aOJnwRVqSjd 7NnfxtLwh7EhTNozcvZc0t3fTt04gbBWqAoImSU9BLrYKY8zNzLF+is5C lwpwNyeUYJdCJfU0DXxDYQBV+dBmNifMFMMjnA3D90031kWY38M5bynNP +ad0VUfI4rKxuNM3+8n9lsJ5I8YBmGBWcvCYNXnUwejaP3TWwXUkQp8wm kN3G8t+pRF6ktTzFG40L0JSbnUlrWOVRjK9dKoR0vkxydJHk4fpRplzC1 OoeUsrWCgF6upp+DKPENY8y3hItAd3R50OsdO4q1PjvCrxnbOy4t9Z1zV w==; X-CSE-ConnectionGUID: 9fhC9J0XTyKuksmsW1Muew== X-CSE-MsgGUID: 5tm3pEN/TqulNra2LThdmQ== X-IronPort-AV: E=McAfee;i="6700,10204,11373"; a="47006360" X-IronPort-AV: E=Sophos;i="6.14,246,1736841600"; d="scan'208";a="47006360" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2025 06:28:39 -0700 X-CSE-ConnectionGUID: bHl5f6TpQmCyhJz0ADKMmw== X-CSE-MsgGUID: ize5yazjQ+WfnC0A+lIf7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,246,1736841600"; d="scan'208";a="121240107" Received: from lkp-server02.sh.intel.com (HELO a4747d147074) ([10.239.97.151]) by orviesa010.jf.intel.com with ESMTP; 14 Mar 2025 06:28:39 -0700 Received: from kbuild by a4747d147074 with local (Exim 4.96) (envelope-from ) id 1tt55W-000AUY-2v; Fri, 14 Mar 2025 13:28:34 +0000 Date: Fri, 14 Mar 2025 21:28:01 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/tty/serial/xilinx_uartps.c:1557 cdns_uart_probe() warn: passing positive error code '(-517)' to 'PTR_ERR' Message-ID: <202503142103.CO4uxaZd-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Rajan Vaja tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 695caca9345a160ecd9645abab8e70cfe849e9ff commit: f694936c3b5a4c140ded5b673555d95aedc866b9 tty: xilinx_uartps: Correct return value in probe date: 6 years ago :::::: branch date: 5 hours ago :::::: commit date: 6 years ago config: i386-randconfig-141-20250314 (https://download.01.org/0day-ci/archive/20250314/202503142103.CO4uxaZd-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202503142103.CO4uxaZd-lkp@intel.com/ New smatch warnings: drivers/tty/serial/xilinx_uartps.c:1557 cdns_uart_probe() warn: passing positive error code '(-517)' to 'PTR_ERR' Old smatch warnings: drivers/tty/serial/xilinx_uartps.c:1572 cdns_uart_probe() warn: passing positive error code '(-517)' to 'PTR_ERR' vim +1557 drivers/tty/serial/xilinx_uartps.c 10a5315b47b09ea Michal Simek 2018-09-03 1532 024ca329bfb9a94 Michal Simek 2018-09-03 1533 rc = uart_register_driver(cdns_uart_uart_driver); e4bbb5194ea3bc7 Michal Simek 2018-09-03 1534 if (rc < 0) { e4bbb5194ea3bc7 Michal Simek 2018-09-03 1535 dev_err(&pdev->dev, "Failed to register driver\n"); ae1cca3fa3478be Michal Simek 2018-09-20 1536 goto err_out_id; e4bbb5194ea3bc7 Michal Simek 2018-09-03 1537 } e4bbb5194ea3bc7 Michal Simek 2018-09-03 1538 024ca329bfb9a94 Michal Simek 2018-09-03 1539 cdns_uart_data->cdns_uart_driver = cdns_uart_uart_driver; 024ca329bfb9a94 Michal Simek 2018-09-03 1540 024ca329bfb9a94 Michal Simek 2018-09-03 1541 /* 024ca329bfb9a94 Michal Simek 2018-09-03 1542 * Setting up proper name_base needs to be done after uart 024ca329bfb9a94 Michal Simek 2018-09-03 1543 * registration because tty_driver structure is not filled. 024ca329bfb9a94 Michal Simek 2018-09-03 1544 * name_base is 0 by default. 024ca329bfb9a94 Michal Simek 2018-09-03 1545 */ bed25ac0e2b6ab8 Michal Simek 2018-09-03 1546 cdns_uart_uart_driver->tty_driver->name_base = cdns_uart_data->id; 46a460f0150ab47 Michal Simek 2018-09-03 1547 3816b2f886d0918 Nava kishore Manne 2016-09-15 1548 match = of_match_node(cdns_uart_of_match, pdev->dev.of_node); 3816b2f886d0918 Nava kishore Manne 2016-09-15 1549 if (match && match->data) { 3816b2f886d0918 Nava kishore Manne 2016-09-15 1550 const struct cdns_platform_data *data = match->data; 3816b2f886d0918 Nava kishore Manne 2016-09-15 1551 3816b2f886d0918 Nava kishore Manne 2016-09-15 1552 cdns_uart_data->quirks = data->quirks; 3816b2f886d0918 Nava kishore Manne 2016-09-15 1553 } 3816b2f886d0918 Nava kishore Manne 2016-09-15 1554 d9bb3fb12685209 Soren Brinkmann 2014-04-04 1555 cdns_uart_data->pclk = devm_clk_get(&pdev->dev, "pclk"); f694936c3b5a4c1 Rajan Vaja 2019-03-01 1556 if (PTR_ERR(cdns_uart_data->pclk) == -EPROBE_DEFER) { f694936c3b5a4c1 Rajan Vaja 2019-03-01 @1557 rc = PTR_ERR(cdns_uart_data->pclk); f694936c3b5a4c1 Rajan Vaja 2019-03-01 1558 goto err_out_unregister_driver; f694936c3b5a4c1 Rajan Vaja 2019-03-01 1559 } f694936c3b5a4c1 Rajan Vaja 2019-03-01 1560 d9bb3fb12685209 Soren Brinkmann 2014-04-04 1561 if (IS_ERR(cdns_uart_data->pclk)) { d9bb3fb12685209 Soren Brinkmann 2014-04-04 1562 cdns_uart_data->pclk = devm_clk_get(&pdev->dev, "aper_clk"); 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1563 if (IS_ERR(cdns_uart_data->pclk)) { 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1564 rc = PTR_ERR(cdns_uart_data->pclk); 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1565 goto err_out_unregister_driver; 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1566 } f694936c3b5a4c1 Rajan Vaja 2019-03-01 1567 dev_err(&pdev->dev, "clock name 'aper_clk' is deprecated.\n"); f694936c3b5a4c1 Rajan Vaja 2019-03-01 1568 } d9bb3fb12685209 Soren Brinkmann 2014-04-04 1569 d9bb3fb12685209 Soren Brinkmann 2014-04-04 1570 cdns_uart_data->uartclk = devm_clk_get(&pdev->dev, "uart_clk"); f694936c3b5a4c1 Rajan Vaja 2019-03-01 1571 if (PTR_ERR(cdns_uart_data->uartclk) == -EPROBE_DEFER) { f694936c3b5a4c1 Rajan Vaja 2019-03-01 1572 rc = PTR_ERR(cdns_uart_data->uartclk); f694936c3b5a4c1 Rajan Vaja 2019-03-01 1573 goto err_out_unregister_driver; f694936c3b5a4c1 Rajan Vaja 2019-03-01 1574 } f694936c3b5a4c1 Rajan Vaja 2019-03-01 1575 d9bb3fb12685209 Soren Brinkmann 2014-04-04 1576 if (IS_ERR(cdns_uart_data->uartclk)) { d9bb3fb12685209 Soren Brinkmann 2014-04-04 1577 cdns_uart_data->uartclk = devm_clk_get(&pdev->dev, "ref_clk"); 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1578 if (IS_ERR(cdns_uart_data->uartclk)) { 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1579 rc = PTR_ERR(cdns_uart_data->uartclk); 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1580 goto err_out_unregister_driver; 82ca0d5487d4e14 Greg Kroah-Hartman 2018-12-06 1581 } f694936c3b5a4c1 Rajan Vaja 2019-03-01 1582 dev_err(&pdev->dev, "clock name 'ref_clk' is deprecated.\n"); f694936c3b5a4c1 Rajan Vaja 2019-03-01 1583 } 2326669ccbd901d Josh Cartwright 2013-01-21 1584 ecfc5771ef0617d Shubhrajyoti Datta 2017-04-06 1585 rc = clk_prepare_enable(cdns_uart_data->pclk); 30e1e28598c2674 Soren Brinkmann 2013-05-13 1586 if (rc) { d9bb3fb12685209 Soren Brinkmann 2014-04-04 1587 dev_err(&pdev->dev, "Unable to enable pclk clock.\n"); e4bbb5194ea3bc7 Michal Simek 2018-09-03 1588 goto err_out_unregister_driver; 30e1e28598c2674 Soren Brinkmann 2013-05-13 1589 } ecfc5771ef0617d Shubhrajyoti Datta 2017-04-06 1590 rc = clk_prepare_enable(cdns_uart_data->uartclk); 2326669ccbd901d Josh Cartwright 2013-01-21 1591 if (rc) { 30e1e28598c2674 Soren Brinkmann 2013-05-13 1592 dev_err(&pdev->dev, "Unable to enable device clock.\n"); d9bb3fb12685209 Soren Brinkmann 2014-04-04 1593 goto err_out_clk_dis_pclk; 61ec9016988f5c0 John Linn 2011-04-30 1594 } 61ec9016988f5c0 John Linn 2011-04-30 1595 61ec9016988f5c0 John Linn 2011-04-30 1596 res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 30e1e28598c2674 Soren Brinkmann 2013-05-13 1597 if (!res) { 30e1e28598c2674 Soren Brinkmann 2013-05-13 1598 rc = -ENODEV; 30e1e28598c2674 Soren Brinkmann 2013-05-13 1599 goto err_out_clk_disable; 30e1e28598c2674 Soren Brinkmann 2013-05-13 1600 } 61ec9016988f5c0 John Linn 2011-04-30 1601 5c90c07b98c0219 Michal Simek 2015-04-13 1602 irq = platform_get_irq(pdev, 0); 5c90c07b98c0219 Michal Simek 2015-04-13 1603 if (irq <= 0) { 5c90c07b98c0219 Michal Simek 2015-04-13 1604 rc = -ENXIO; 30e1e28598c2674 Soren Brinkmann 2013-05-13 1605 goto err_out_clk_disable; 30e1e28598c2674 Soren Brinkmann 2013-05-13 1606 } 61ec9016988f5c0 John Linn 2011-04-30 1607 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki