From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Filipe Xavier" <felipeaggger@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, felipe_life@live.com
Subject: Re: [PATCH] rust: add new macro for common bitwise operations
Date: Fri, 14 Mar 2025 16:02:35 +0100 [thread overview]
Message-ID: <2025031444-acre-boxlike-8af1@gregkh> (raw)
In-Reply-To: <1A434368-6B92-4C64-8B5A-17499C8E2F1B@collabora.com>
On Fri, Mar 14, 2025 at 11:18:56AM -0300, Daniel Almeida wrote:
> Hi Greg,
>
> > On 4 Mar 2025, at 11:09, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Nice, but why not use the same api/names that are already in the kernel
> > for this type of functionality in the C .h files? That way we have
> > consistent names everywhere?
> >
> > thanks,
> >
> > greg k-h
>
> IIUC, there is already someone working on that [0].
Great!
> Can we just leave this macro somewhat as-is as a mere convenience for driver authors?
Why have multiple apis for the same thing? That just makes reviewers
confused as well as developers. We don't do that for C code :)
> My latest review comments include a name change to make it less confusing in this regard.
I would just like parity where ever possible to make things easier for
everyone.
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-14 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 12:55 [PATCH] rust: add new macro for common bitwise operations Filipe Xavier
2025-03-04 12:57 ` Alice Ryhl
2025-03-10 13:31 ` Miguel Ojeda
2025-03-17 21:36 ` Lyude Paul
2025-03-04 14:09 ` Greg KH
2025-03-05 12:46 ` Filipe Xavier
2025-03-05 14:18 ` Greg KH
2025-03-14 14:18 ` Daniel Almeida
2025-03-14 15:02 ` Greg KH [this message]
2025-03-17 15:00 ` Alice Ryhl
2025-03-10 13:33 ` Miguel Ojeda
2025-03-13 0:40 ` kernel test robot
2025-03-14 14:09 ` Daniel Almeida
2025-03-17 21:40 ` Lyude Paul
-- strict thread matches above, loose matches on Subject: below --
2025-03-12 16:42 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025031444-acre-boxlike-8af1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=felipe_life@live.com \
--cc=felipeaggger@gmail.com \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.