From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/nolibc: drop manual stack pointer alignment
Date: Mon, 17 Mar 2025 08:18:36 +0100 [thread overview]
Message-ID: <20250317071836.GA5114@1wt.eu> (raw)
In-Reply-To: <20250316-nolibc-sp-align-v1-1-1e1fb073ca1e@weissschuh.net>
On Sun, Mar 16, 2025 at 08:46:07PM +0100, Thomas Weißschuh wrote:
> The stack pointer is already aligned by the kernel to a multiple of 16.
> See STACK_ROUND() in fs/binfmt_elf.c.
>
> The manual realignment is unnecessary, drop it.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Looks good to me, thanks Thomas!
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
prev parent reply other threads:[~2025-03-17 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 19:46 [PATCH] tools/nolibc: drop manual stack pointer alignment Thomas Weißschuh
2025-03-17 7:18 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317071836.GA5114@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.