From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: bin.lan.cn@windriver.com, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1.y] leds: mlxreg: Use devm_mutex_init() for mutex initialization
Date: Mon, 17 Mar 2025 12:40:15 -0400 [thread overview]
Message-ID: <20250317091357-20ecaee5e20b7b45@stable.kernel.org> (raw)
In-Reply-To: <20250317050902.1151438-1-bin.lan.cn@windriver.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: efc347b9efee1c2b081f5281d33be4559fa50a16
WARNING: Author mismatch between patch and upstream commit:
Backport author: bin.lan.cn@windriver.com
Commit author: George Stark<gnstark@salutedevices.com>
Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: 172ffd26a5af)
Note: The patch differs from the upstream commit:
---
1: efc347b9efee1 ! 1: 86f4e68bf53db leds: mlxreg: Use devm_mutex_init() for mutex initialization
@@ Metadata
## Commit message ##
leds: mlxreg: Use devm_mutex_init() for mutex initialization
+ [ Upstream commit efc347b9efee1c2b081f5281d33be4559fa50a16 ]
+
In this driver LEDs are registered using devm_led_classdev_register()
so they are automatically unregistered after module's remove() is done.
led_classdev_unregister() calls module's led_set_brightness() to turn off
@@ Commit message
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240411161032.609544-8-gnstark@salutedevices.com
Signed-off-by: Lee Jones <lee@kernel.org>
+ Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
+ Signed-off-by: He Zhe <zhe.he@windriver.com>
## drivers/leds/leds-mlxreg.c ##
@@ drivers/leds/leds-mlxreg.c: static int mlxreg_led_probe(struct platform_device *pdev)
@@ drivers/leds/leds-mlxreg.c: static int mlxreg_led_probe(struct platform_device *
return mlxreg_led_config(priv);
}
--static void mlxreg_led_remove(struct platform_device *pdev)
+-static int mlxreg_led_remove(struct platform_device *pdev)
-{
- struct mlxreg_led_priv_data *priv = dev_get_drvdata(&pdev->dev);
-
- mutex_destroy(&priv->access_lock);
+-
+- return 0;
-}
-
static struct platform_driver mlxreg_led_driver = {
@@ drivers/leds/leds-mlxreg.c: static int mlxreg_led_probe(struct platform_device *
.name = "leds-mlxreg",
},
.probe = mlxreg_led_probe,
-- .remove_new = mlxreg_led_remove,
+- .remove = mlxreg_led_remove,
};
module_platform_driver(mlxreg_led_driver);
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Success |
prev parent reply other threads:[~2025-03-17 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 5:09 [PATCH 6.1.y] leds: mlxreg: Use devm_mutex_init() for mutex initialization bin.lan.cn
2025-03-17 16:40 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317091357-20ecaee5e20b7b45@stable.kernel.org \
--to=sashal@kernel.org \
--cc=bin.lan.cn@windriver.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.