From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <borisp@nvidia.com>, <davem@davemloft.net>,
<eric.dumazet@gmail.com>, <horms@kernel.org>,
<john.fastabend@gmail.com>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <ncardwell@google.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/2] tcp/dccp: remove icsk->icsk_timeout
Date: Mon, 17 Mar 2025 13:21:56 -0700 [thread overview]
Message-ID: <20250317202232.23864-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250317085313.2023214-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 17 Mar 2025 15:14:00 +0000
> icsk->icsk_timeout can be replaced by icsk->icsk_retransmit_timer.expires
>
> This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
We may want to add a paired WRITE_ONCE() in __mod_timer() later.
Btw, DCCP removal series is almost ready and I will post it
in the next cycle as the patch queue is long now.
next prev parent reply other threads:[~2025-03-17 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 8:53 [PATCH net-next] tcp: move icsk_clean_acked to a better location Eric Dumazet
2025-03-17 14:55 ` Neal Cardwell
2025-03-17 16:17 ` Sabrina Dubroca
2025-03-17 20:21 ` Kuniyuki Iwashima [this message]
2025-03-17 20:30 ` Kuniyuki Iwashima
2025-03-24 17:40 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2025-03-17 15:13 [PATCH net-next 0/2] tcp/dccp: remove 16 bytes from icsk Eric Dumazet
2025-03-17 15:14 ` [PATCH net-next 1/2] tcp/dccp: remove icsk->icsk_timeout Eric Dumazet
2025-03-17 20:24 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317202232.23864-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.