All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-efi@vger.kernel.org
Subject: [efi:urgent 10/10] fs/efivarfs/super.c:424:34: error: 'INODE_CHILD' undeclared; did you mean 'I_MUTEX_CHILD'?
Date: Mon, 17 Mar 2025 23:08:07 +0800	[thread overview]
Message-ID: <202503172331.vqCmniUS-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git urgent
head:   2379221e8c43a4be62811f4d8a71cfffc23df5b0
commit: 2379221e8c43a4be62811f4d8a71cfffc23df5b0 [10/10] efivarfs: use INODE_CHILD nested lock to traverse variables on resume
config: riscv-randconfig-001-20250317 (https://download.01.org/0day-ci/archive/20250317/202503172331.vqCmniUS-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250317/202503172331.vqCmniUS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503172331.vqCmniUS-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/efivarfs/super.c: In function 'efivarfs_actor':
>> fs/efivarfs/super.c:424:34: error: 'INODE_CHILD' undeclared (first use in this function); did you mean 'I_MUTEX_CHILD'?
     424 |         inode_lock_nested(inode, INODE_CHILD);
         |                                  ^~~~~~~~~~~
         |                                  I_MUTEX_CHILD
   fs/efivarfs/super.c:424:34: note: each undeclared identifier is reported only once for each function it appears in


vim +424 fs/efivarfs/super.c

   401	
   402	static bool efivarfs_actor(struct dir_context *ctx, const char *name, int len,
   403				   loff_t offset, u64 ino, unsigned mode)
   404	{
   405		unsigned long size;
   406		struct efivarfs_ctx *ectx = container_of(ctx, struct efivarfs_ctx, ctx);
   407		struct qstr qstr = { .name = name, .len = len };
   408		struct dentry *dentry = d_hash_and_lookup(ectx->sb->s_root, &qstr);
   409		struct inode *inode;
   410		struct efivar_entry *entry;
   411		int err;
   412	
   413		if (IS_ERR_OR_NULL(dentry))
   414			return true;
   415	
   416		inode = d_inode(dentry);
   417		entry = efivar_entry(inode);
   418	
   419		err = efivar_entry_size(entry, &size);
   420		size += sizeof(__u32);	/* attributes */
   421		if (err)
   422			size = 0;
   423	
 > 424		inode_lock_nested(inode, INODE_CHILD);
   425		i_size_write(inode, size);
   426		inode_unlock(inode);
   427	
   428		if (!size) {
   429			ectx->dentry = dentry;
   430			return false;
   431		}
   432	
   433		dput(dentry);
   434	
   435		return true;
   436	}
   437	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-03-17 15:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202503172331.vqCmniUS-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.