All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: xie.ludan@zte.com.cn
Cc: andreas@gaisler.com, davem@davemloft.net, ukleinek@kernel.org,
	jonathan.cameron@huawei.com, mathieu.poirier@linaro.org,
	quic_zijuhu@quicinc.com, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, xu.xin16@zte.com.cn,
	yang.yang29@zte.com.cn
Subject: Re: [PATCH linux-next] sparc/vio: use sysfs_emit() instead of scnprintf().
Date: Mon, 17 Mar 2025 14:54:45 +0100	[thread overview]
Message-ID: <2025031743-cheating-latch-ba8f@gregkh> (raw)
In-Reply-To: <20250317160456854fAJoK7WQI_J5R7rPeyfxh@zte.com.cn>

On Mon, Mar 17, 2025 at 04:04:56PM +0800, xie.ludan@zte.com.cn wrote:
> From: XieLudan <xie.ludan@zte.com.cn>
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: XieLudan <xie.ludan@zte.com.cn>
> ---
>  arch/sparc/kernel/vio.c | 2 +-

Do you have this hardware and have tested it?  If not, I wouldn't mess
with existing code, just follow the documentation for new submissions,
leave old stuff alone as it's already working.

thanks,

greg k-h

      reply	other threads:[~2025-03-17 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17  8:04 [PATCH linux-next] sparc/vio: use sysfs_emit() instead of scnprintf() xie.ludan
2025-03-17 13:54 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025031743-cheating-latch-ba8f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=quic_zijuhu@quicinc.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=xie.ludan@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.