All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qi.Chen@windriver.com
To: openembedded-core@lists.openembedded.org
Cc: Ross.Burton@arm.com
Subject: [OE-core][PATCH V2] systemd: do not delete systemd-getty-generator
Date: Tue, 18 Mar 2025 23:40:16 -0700	[thread overview]
Message-ID: <20250319064016.1119702-1-Qi.Chen@windriver.com> (raw)

From: Chen Qi <Qi.Chen@windriver.com>

Some BSPs don't set SERIAL_CONSOLES. They need systemd-getty-generator[1]
be there to work. This generator has been there for a few previous
releases, we don't see any problem it brings up. So let's keep it.

[1] https://www.freedesktop.org/software/systemd/man/latest/systemd-getty-generator.html

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/systemd/systemd_257.3.bb | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_257.3.bb b/meta/recipes-core/systemd/systemd_257.3.bb
index 64fb8fe69a..edaa2f33e3 100644
--- a/meta/recipes-core/systemd/systemd_257.3.bb
+++ b/meta/recipes-core/systemd/systemd_257.3.bb
@@ -288,12 +288,6 @@ do_install() {
 	fi
 	install -d ${D}/${base_sbindir}
 
-	if ! ${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', 'true', 'false', d)}; then
-		# Remove the serial-getty generator and instead use explicit services
-		# created by the systemd-serialgetty recipe
-		find ${D} -name \*getty-generator\* -delete
-	fi
-
 	# Provide support for initramfs
 	[ ! -e ${D}/init ] && ln -s ${nonarch_libdir}/systemd/systemd ${D}/init
 	[ ! -e ${D}/${base_sbindir}/udevd ] && ln -s ${nonarch_libdir}/systemd/systemd-udevd ${D}/${base_sbindir}/udevd
-- 
2.48.1



             reply	other threads:[~2025-03-19  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  6:40 Qi.Chen [this message]
2025-03-25 17:50 ` [OE-core][PATCH V2] systemd: do not delete systemd-getty-generator Ross Burton
2025-03-26  2:55   ` ChenQi
     [not found]   ` <18303ADA6731991F.6378@lists.openembedded.org>
2025-04-02  5:14     ` ChenQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250319064016.1119702-1-Qi.Chen@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=Ross.Burton@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.