From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Subject: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts
Date: Wed, 19 Mar 2025 12:54:33 +0200 [thread overview]
Message-ID: <20250319105813.3102076-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250319105813.3102076-1-andriy.shevchenko@linux.intel.com>
The PHY_ID_FMT is defined with '%02x' which is _minumum_ digits
to be printed. This, in particular, may trigger GCC warning, when
the parameter for the above mentioned specifier is bigger than
a byte. Avoid this, by limiting the amount of digits to be printed
to two. This is okay as the PHY maximum address is 31 and it fits.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 19f076a71f94..3b18c241f33e 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -309,7 +309,7 @@ static inline long rgmii_clock(int speed)
#define PHY_MAX_ADDR 32
/* Used when trying to connect to a specific phy (mii bus id:phy device id) */
-#define PHY_ID_FMT "%s:%02x"
+#define PHY_ID_FMT "%s:%02hhx"
#define MII_BUS_ID_SIZE 61
--
2.47.2
next prev parent reply other threads:[~2025-03-19 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 10:54 [PATCH net v2 0/2] net: phy: Fix potential string cut when using PHY_ID_FMT Andy Shevchenko
2025-03-19 10:54 ` Andy Shevchenko [this message]
2025-03-19 11:21 ` [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts Andy Shevchenko
2025-03-19 15:37 ` kernel test robot
2025-03-19 15:52 ` Andy Shevchenko
2025-03-19 15:46 ` Russell King (Oracle)
2025-03-19 16:16 ` Andy Shevchenko
2025-03-19 17:27 ` kernel test robot
2025-03-19 10:54 ` [PATCH net v2 2/2] net: usb: asix: ax88772: Increase phy_name size Andy Shevchenko
2025-03-19 11:26 ` Andy Shevchenko
2025-03-19 14:43 ` Russell King (Oracle)
2025-03-19 16:22 ` Andy Shevchenko
2025-03-19 17:13 ` Russell King (Oracle)
2025-03-19 18:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319105813.3102076-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.