From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PULL 3/8] tests/functional: remove all class level fields
Date: Wed, 19 Mar 2025 14:18:46 +0100 [thread overview]
Message-ID: <20250319131851.148817-4-thuth@redhat.com> (raw)
In-Reply-To: <20250319131851.148817-1-thuth@redhat.com>
From: Daniel P. Berrangé <berrange@redhat.com>
A number of fields are set at the class level on QemuBaseTest, even
though the exact same named field is then set at the object level
later in most cases.
The 'self.logger' initialization in ACPI bits test needs to be removed
since 'self.log' won't exist at that point in the flow. It already
initialized 'self.logger' later in the setUp() method, so the __init__
method was redundant.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20250317124300.84266-1-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/functional/qemu_test/testcase.py | 6 ------
tests/functional/test_acpi_bits.py | 1 -
2 files changed, 7 deletions(-)
diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
index 50d232a7c63..50c401b8c3c 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -33,12 +33,6 @@
class QemuBaseTest(unittest.TestCase):
- arch = None
-
- workdir = None
- log = None
- logdir = None
-
'''
@params compressed: filename, Asset, or file-like object to uncompress
@params format: optional compression format (gzip, lzma)
diff --git a/tests/functional/test_acpi_bits.py b/tests/functional/test_acpi_bits.py
index 20da4356873..8e0563a97b1 100755
--- a/tests/functional/test_acpi_bits.py
+++ b/tests/functional/test_acpi_bits.py
@@ -119,7 +119,6 @@ def __init__(self, *args, **kwargs):
self._debugcon_addr = '0x403'
self._debugcon_log = 'debugcon-log.txt'
- self.logger = self.log
def _print_log(self, log):
self.logger.info('\nlogs from biosbits follows:')
--
2.48.1
next prev parent reply other threads:[~2025-03-19 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 13:18 [PULL 0/8] Functional and s390x patches for v10.0-rc1 Thomas Huth
2025-03-19 13:18 ` [PULL 1/8] hw/virtio: Also include md stubs in case CONFIG_VIRTIO_PCI is not set Thomas Huth
2025-03-19 13:18 ` [PULL 2/8] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine' Thomas Huth
2025-03-19 13:18 ` Thomas Huth [this message]
2025-03-19 13:18 ` [PULL 4/8] docs/system: Use the meson binary from the pyvenv Thomas Huth
2025-03-19 13:18 ` [PULL 5/8] docs/system/arm: Use "functional tests" instead of "integration tests" Thomas Huth
2025-03-19 13:18 ` [PULL 6/8] docs/devel/testing/functional: Add a section about logging Thomas Huth
2025-03-19 13:18 ` [PULL 7/8] tests/functional/test_x86_64_kvm_xen: Remove avocado tags Thomas Huth
2025-03-19 13:18 ` [PULL 8/8] tests/functional/test_migration: Use "ncat" instead of "nc" in the exec test Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319131851.148817-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.