From: Simon Horman <horms@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v8 09/10] net: gianfar: Use device_get_child_node_count_named()
Date: Wed, 19 Mar 2025 16:07:28 +0000 [thread overview]
Message-ID: <20250319160728.GA776230@kernel.org> (raw)
In-Reply-To: <95b6015cd5f6fcce535982118543d47504ed609f.1742225817.git.mazziesaccount@gmail.com>
On Mon, Mar 17, 2025 at 05:52:25PM +0200, Matti Vaittinen wrote:
> We can avoid open-coding the loop construct which counts firmware child
> nodes with a specific name by using the newly added
> device_get_child_node_count_named().
>
> The gianfar driver has such open-coded loop. Replace it with the
> device_get_child_node_count_named().
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This patch looks good to me.
But I think it would be best to resubmit it,
as a standalone patch for net-next, once
it's dependencies are present in net-next.
--
pw-bot: defer
next prev parent reply other threads:[~2025-03-19 16:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 15:49 [PATCH v8 00/10] Support ROHM BD79124 ADC Matti Vaittinen
2025-03-17 15:50 ` [PATCH v8 01/10] dt-bindings: ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-17 15:50 ` [PATCH v8 02/10] property: Add functions to iterate named child Matti Vaittinen
2025-03-18 15:24 ` Sakari Ailus
2025-03-19 6:02 ` Matti Vaittinen
2025-03-19 15:23 ` Sakari Ailus
2025-03-20 6:43 ` Matti Vaittinen
2025-03-30 16:07 ` Jonathan Cameron
2025-03-17 15:50 ` [PATCH v8 03/10] iio: adc: add helpers for parsing ADC nodes Matti Vaittinen
2025-03-17 16:01 ` Andy Shevchenko
2025-03-17 15:51 ` [PATCH v8 04/10] iio: adc: rzg2l_adc: Use adc-helpers Matti Vaittinen
2025-03-17 16:02 ` Andy Shevchenko
2025-03-17 15:51 ` [PATCH v8 05/10] iio: adc: sun20i-gpadc: " Matti Vaittinen
2025-03-17 16:03 ` Andy Shevchenko
2025-03-17 15:51 ` [PATCH v8 06/10] iio: adc: Support ROHM BD79124 ADC Matti Vaittinen
2025-03-17 16:43 ` Andy Shevchenko
2025-03-18 7:35 ` Matti Vaittinen
2025-03-17 15:51 ` [PATCH v8 07/10] MAINTAINERS: Add IIO ADC helpers Matti Vaittinen
2025-03-17 15:51 ` [PATCH v8 08/10] MAINTAINERS: Add ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-17 15:52 ` [PATCH net-next v8 09/10] net: gianfar: Use device_get_child_node_count_named() Matti Vaittinen
2025-03-19 16:07 ` Simon Horman [this message]
2025-03-20 6:12 ` Matti Vaittinen
2025-03-17 15:52 ` [PATCH v8 10/10] media: thp7312: Use helper for iterating named child nodes Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319160728.GA776230@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=djrscally@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.