From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v2 net-next 5/7] nexthop: Remove redundant group len check in nexthop_create_group().
Date: Wed, 19 Mar 2025 16:06:50 -0700 [thread overview]
Message-ID: <20250319230743.65267-6-kuniyu@amazon.com> (raw)
In-Reply-To: <20250319230743.65267-1-kuniyu@amazon.com>
The number of NHA_GROUP entries is guaranteed to be non-zero in
nh_check_attr_group().
Let's remove the redundant check in nexthop_create_group().
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/nexthop.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index fb129c830040..c552bb46aa23 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -2692,9 +2692,6 @@ static struct nexthop *nexthop_create_group(struct net *net,
int err;
int i;
- if (WARN_ON(!num_nh))
- return ERR_PTR(-EINVAL);
-
nh = nexthop_alloc();
if (!nh)
return ERR_PTR(-ENOMEM);
--
2.48.1
next prev parent reply other threads:[~2025-03-19 23:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 23:06 [PATCH v2 net-next 0/7] nexthop: Convert RTM_{NEW,DEL}NEXTHOP to per-netns RTNL Kuniyuki Iwashima
2025-03-19 23:06 ` [PATCH v2 net-next 1/7] nexthop: Move nlmsg_parse() in rtm_to_nh_config() to rtm_new_nexthop() Kuniyuki Iwashima
2025-03-20 3:13 ` David Ahern
2025-03-20 7:00 ` Eric Dumazet
2025-03-19 23:06 ` [PATCH v2 net-next 2/7] nexthop: Split nh_check_attr_group() Kuniyuki Iwashima
2025-03-20 7:05 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 3/7] nexthop: Move NHA_OIF validation to rtm_to_nh_config_rtnl() Kuniyuki Iwashima
2025-03-20 7:06 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 4/7] nexthop: Check NLM_F_REPLACE and NHA_ID in rtm_new_nexthop() Kuniyuki Iwashima
2025-03-20 7:07 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` Kuniyuki Iwashima [this message]
2025-03-20 7:07 ` [PATCH v2 net-next 5/7] nexthop: Remove redundant group len check in nexthop_create_group() Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 6/7] nexthop: Convert RTM_NEWNEXTHOP to per-netns RTNL Kuniyuki Iwashima
2025-03-20 7:12 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 7/7] nexthop: Convert RTM_DELNEXTHOP " Kuniyuki Iwashima
2025-03-20 7:12 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-24 9:35 ` [PATCH v2 net-next 0/7] nexthop: Convert RTM_{NEW,DEL}NEXTHOP " Ido Schimmel
2025-03-24 19:03 ` Kuniyuki Iwashima
2025-03-25 15:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319230743.65267-6-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.