Re: [EXTERNAL] Re: [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12

[Denys Dmytriyenko <denis@denix.org>]

On Wed, Mar 19, 2025 at 01:22:41PM -0500, Antonios Christidis wrote:
> 
> On 3/18/25 4:38 PM, Denys Dmytriyenko wrote:
> >On Tue, Mar 18, 2025 at 04: 01: 37PM -0500, Andrew Davis via
> >lists. yoctoproject. org wrote: > On 3/17/25 9: 38 PM, Antonios
> >Christidis via lists. yoctoproject. org wrote: > >From: Antonios
> >Christidis <a-christidis@ ti. com> > >
> >ZjQcmQRYFpfptBannerStart
> >This message was sent from outside of Texas Instruments.
> >Do not click links or open attachments unless you recognize the
> >source of this email and know the content is safe.
> >Report Suspicious
> ><https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uPdqXRfP1m17CwYkHLKDfHEYvlwyW_vqb9VOfJCHARPcQCe_gAXq208Sc3o-G_CVgqCM4tPnpSqs9A$>
> >
> >ZjQcmQRYFpfptBannerEnd
> >On Tue, Mar 18, 2025 at 04:01:37PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> >> On 3/17/25 9:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> >> >From: Antonios Christidis <a-christidis@ti.com>
> >> >
> >> >The user mode libraries needed recompiling with the scarthgap revision of gcc to
> >> >remove all the warnings about 32bit API usage during the linking stage, new
> >> >SRCREV and branch includes this changes. Versions of the libraries remain the
> >> >same.
> >> >
> >> >Signed-off-by: Antonios Christidis <a-christidis@ti>
> >> >---
> >> >v5:
> >> >- Move the symb link of libGAL.so within the ${PN} package. While making
> >> >   sure the header files are part of the ${PN}-dev package.
> >> >
> >> >v3:
> >> >- Removed commented lines and extra lib directory that was being created
> >> >   in do_install()
> >> >
> >> >v2:
> >> >- No longer include withing the PN package /usr/include file and symb
> >> >   link to library file. This is done by not chaning the FILES/PACKAGES
> >> >   variables, thus creating a -dev package.
> >> >
> >> >  .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
> >> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >> >
> >> >diff --git a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >> >index 807f421c..6b7226ab 100644
> >> >--- a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >> >+++ b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >> >@@ -11,10 +11,10 @@ COMPATIBLE_MACHINE = "omap-a15"
> >> >  CLEANBROKEN = "1"
> >> >-BRANCH = "ti-${PV}"
> >> >+BRANCH = "ti-${PV}-scarthgap"
> >> >  SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-libs.git;protocol=https;branch=${BRANCH}"
> >> >-SRCREV = "c0afab259de59909cfe74c01f3f7fbaa147f94b5"
> >> >+SRCREV = "85c175e8425c33dda6e272aeb45afe0f69a79096"
> >> >  RRECOMMENDS:${PN} = "ti-gc320-driver"
> >> >@@ -43,4 +43,6 @@ do_install() {
> >> >      chown -R root:root ${D}
> >> >  }
> >> >-INSANE_SKIP:${PN} += "ldflags"
> >> >+FILES:${PN}:append = " ${libdir}"
> >> > FILES:${PN} += "${libdir}" ?
> >
> >1. I agree it's best not to use blank :append overrides and instead use +=
> >2. ${libdir} is already a default and doesn't need to be added explicitly
> 
> Regarding #1, moving forward I'll prefer to use "+=" instead of the
> "append". This will be included in a new version of the series.
> Regarding #2, the default search pattern for ${PN} packages is:
> "/usr/lib/lib*.so.* /usr/lib/*.so.*" so the symb link would never
> get included in the ${PN} package. I was not clear enough when
> making my change, but by explicitly stating ${libdir} the symb link
> is included in the ${PN} package.

As I had previously detailed in another thread to you[1], the best approach 
is to override SOLIBS and FILES_SOLIBSDEV variables to make it explicit:
[1] https://lists.yoctoproject.org/g/meta-arago/message/15960

SOLIBS = ".so"
FILES_SOLIBSDEV = ""

It is also acceptable to adjust FILES:${PN} for the same, but you do want to 
explain it, e.g. in the comment...

-- 
Denys