From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Sasha Levin <sashal@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
stable@vger.kernel.org, David Howells <dhowells@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Jan Stancek <jstancek@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev,
R Nageswara Sastry <rnsastry@linux.ibm.com>,
Neal Gompa <neal@gompa.dev>
Subject: Re: [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3
Date: Wed, 19 Mar 2025 07:13:13 -0700 [thread overview]
Message-ID: <2025031943-disparity-dash-cfa3@gregkh> (raw)
In-Reply-To: <20250319064031.2971073-4-chenhuacai@loongson.cn>
On Wed, Mar 19, 2025 at 02:40:31PM +0800, Huacai Chen wrote:
> From: Jan Stancek <jstancek@redhat.com>
>
> commit 558bdc45dfb2669e1741384a0c80be9c82fa052c upstream.
>
> ENGINE API has been deprecated since OpenSSL version 3.0 [1].
> Distros have started dropping support from headers and in future
> it will likely disappear also from library.
>
> It has been superseded by the PROVIDER API, so use it instead
> for OPENSSL MAJOR >= 3.
>
> [1] https://github.com/openssl/openssl/blob/master/README-ENGINES.md
>
> [jarkko: fixed up alignment issues reported by checkpatch.pl --strict]
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
> Reviewed-by: Neal Gompa <neal@gompa.dev>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++-------------
> scripts/sign-file.c | 93 ++++++++++++++++++++++++++------------
> 2 files changed, 138 insertions(+), 58 deletions(-)
This seems to differ from what is upstream by a lot, please document
what you changed from it and why when you resend this series again.
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-19 14:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 6:40 [PATCH 6.1&6.6 V3 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0 Huacai Chen
2025-03-19 6:40 ` [PATCH 6.1&6.6 V3 1/3] sign-file,extract-cert: move common SSL helper functions to a header Huacai Chen
2025-03-19 10:54 ` Sasha Levin
2025-03-19 6:40 ` [PATCH 6.1&6.6 V3 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line() Huacai Chen
2025-03-19 10:54 ` Sasha Levin
2025-03-19 6:40 ` [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 Huacai Chen
2025-03-19 10:54 ` Sasha Levin
2025-03-19 14:13 ` Greg Kroah-Hartman [this message]
2025-03-19 14:44 ` Jan Stancek
2025-03-19 16:25 ` Greg Kroah-Hartman
2025-03-19 16:53 ` Jan Stancek
2025-03-20 3:01 ` Huacai Chen
2025-03-30 13:07 ` Huacai Chen
2025-03-30 13:40 ` Jan Stancek
2025-04-14 13:52 ` Huacai Chen
2025-04-22 7:53 ` Greg Kroah-Hartman
2025-04-22 12:30 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025031943-disparity-dash-cfa3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jarkko@kernel.org \
--cc=jstancek@redhat.com \
--cc=kernel@xen0n.name \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=neal@gompa.dev \
--cc=rnsastry@linux.ibm.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.