Re: [RFC -next 04/10] splice: Add SPLICE_F_ZC and attach ubuf

[kernel test robot <lkp@intel.com>]

Hi Joe,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 2e72b1e0aac24a12f3bf3eec620efaca7ab7d4de]

url:    https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/splice-Add-ubuf_info-to-prepare-for-ZC/20250319-082153
base:   2e72b1e0aac24a12f3bf3eec620efaca7ab7d4de
patch link:    https://lore.kernel.org/r/20250319001521.53249-5-jdamato%40fastly.com
patch subject: [RFC -next 04/10] splice: Add SPLICE_F_ZC and attach ubuf
config: um-randconfig-001-20250320 (https://download.01.org/0day-ci/archive/20250320/202503200330.NdABAJg7-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250320/202503200330.NdABAJg7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503200330.NdABAJg7-lkp@intel.com/

All errors (new ones prefixed by >>):

   /usr/bin/ld: fs/splice.o: in function `do_splice_direct_actor':
>> fs/splice.c:1232: undefined reference to `sock_from_file'
>> /usr/bin/ld: fs/splice.c:1236: undefined reference to `msg_zerocopy_realloc'
   collect2: error: ld returned 1 exit status


vim +1232 fs/splice.c

  1208	
  1209	static ssize_t do_splice_direct_actor(struct file *in, loff_t *ppos,
  1210					      struct file *out, loff_t *opos,
  1211					      size_t len, unsigned int flags,
  1212					      splice_direct_actor *actor)
  1213	{
  1214		struct splice_desc sd = {
  1215			.len		= len,
  1216			.total_len	= len,
  1217			.flags		= flags,
  1218			.pos		= *ppos,
  1219			.u.file		= out,
  1220			.splice_eof	= direct_file_splice_eof,
  1221			.opos		= opos,
  1222		};
  1223		ssize_t ret;
  1224	
  1225		if (unlikely(!(out->f_mode & FMODE_WRITE)))
  1226			return -EBADF;
  1227	
  1228		if (unlikely(out->f_flags & O_APPEND))
  1229			return -EINVAL;
  1230	
  1231		if (unlikely(flags & SPLICE_F_ZC)) {
> 1232			struct socket *sock = sock_from_file(out);
  1233			struct sock *sk = sock->sk;
  1234			struct ubuf_info *ubuf_info;
  1235	
> 1236			ubuf_info = msg_zerocopy_realloc(sk, len, NULL);
  1237			if (!ubuf_info)
  1238				return -ENOMEM;
  1239			sd.ubuf_info = ubuf_info;
  1240		}
  1241	
  1242		ret = splice_direct_to_actor(in, &sd, actor);
  1243		if (ret > 0)
  1244			*ppos = sd.pos;
  1245	
  1246		if (unlikely(flags & SPLICE_F_ZC))
  1247			refcount_dec(&sd.ubuf_info->refcnt);
  1248	
  1249		return ret;
  1250	}
  1251	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki